After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336077 - port from popt to GOption
port from popt to GOption
Status: RESOLVED FIXED
Product: gnome-keyring-manager
Classification: Deprecated
Component: general
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Keyring manager maintainers
Keyring manager maintainers
Depends on: 336085
Blocks:
 
 
Reported: 2006-03-26 13:26 UTC by Sebastien Bacher
Modified: 2006-08-02 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popt to GOption (1.45 KB, patch)
2006-03-26 13:27 UTC, Sebastien Bacher 		none Details | Review
patch updated according to comment (1.69 KB, patch)
2006-03-26 14:46 UTC, Sebastien Bacher 		none Details | Review

Description Sebastien Bacher 2006-03-26 13:26:52 UTC 
As described on http://live.gnome.org/GnomeGoals/PoptGOption, making the desktop using GOption would be nice, patch coming
Comment 1 Sebastien Bacher 2006-03-26 13:27:41 UTC 
Created attachment 62037 [details] [review]
popt to GOption
Comment 2 Claudio Saavedra 2006-03-26 14:05:10 UTC 
From attachment 62037 [details] [review]:

>+  context = g_option_context_new (_("Keyring Manager"));

I think that the parameter of g_option_context_new () is intended to put the application arguments (if any), and not the application name, because that string will be displayed after "Usage:  gnome-keyring-manager [OPTION...]" and 

  Usage:
  gnome-keyring-manager [OPTION...] Keyring Manager

Is not the right way to use the program.

Maybe a dash before the application name would be enough, but I would simply pass NULL.
Comment 3 Sebastien Bacher 2006-03-26 14:46:43 UTC 
Created attachment 62043 [details] [review]
patch updated according to comment

good point, most of other patches for GOption (cf wiki page) do the same, updating the wiki page with a note about that could be useful
Comment 4 Claudio Saavedra 2006-03-26 15:24:56 UTC 
I filed a bug in glib regarding this parameter. I will add a dependence on it.
Comment 5 Fernando Herrera 2006-08-02 11:44:55 UTC 
Thanks a lot. committed to HEAD:
2006-08-02  Fernando Herrera  <fherrera@onirica.com>

        * src/gnome-keyring-manager.c: (main): Port to GOption API. Patch by
        Sebastien Bacher. Closes bug #336077