After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335991 - Running on Battery/AC twice displayed in dialog
Running on Battery/AC twice displayed in dialog
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-preferences
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-03-25 18:36 UTC by Jaap A. Haitsma
Modified: 2006-03-25 22:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (21.74 KB, patch)
2006-03-25 18:39 UTC, Jaap A. Haitsma 		none Details | Review

Description Jaap A. Haitsma 2006-03-25 18:36:42 UTC 
Patch coming up
Comment 1 Jaap A. Haitsma 2006-03-25 18:39:05 UTC 
Created attachment 61995 [details] [review]
Patch

2006-03-25  Jaap Haitsma  <jaap@haitsma.org>

	* data/gpm-prefs.glade: Change "Running on Battery" and "Running on AC"
	labels inside the tab to "Sleep" as they are already on the tabs. 
	Add a Brightness label to the brightness sliders.
	Change all the widget names to *battery* i.s.o. *batteries*
	* src/gpm-prefs.c: Update because of changes in gpm-prefs.glade and some
	refactoring

OK to commit?
Comment 2 Richard Hughes 2006-03-25 18:47:48 UTC 
Trivial problem: Theres a different spacing between "Brightness" and "Set display Brightness to:" on the two tabs.

Fix that, and then it's good to commit, thanks.

The UI is looking really good now, thanks for spending some time on this.

Richard.
Comment 3 Richard Hughes 2006-03-25 19:13:30 UTC 
Can you also do a cvs up before you commit -- I've just committed a small patch myself (doesn't affect your patch) but ChangleLog might need refreshing.

Thanks.
Comment 4 Jaap A. Haitsma 2006-03-25 22:57:16 UTC 
Committed. Spacing was due to the fact that all the vboxes had expand set to TRUE. I now turned them off