After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335877 - Patch to change EOG over to GOption
Patch to change EOG over to GOption
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-24 19:10 UTC by dorrin
Modified: 2006-03-27 00:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to convert EoG to GOption (3.17 KB, patch)
2006-03-24 19:11 UTC, dorrin
none Details | Review
Patch to make eog use goption (4.03 KB, patch)
2006-03-24 19:25 UTC, Michael Plump
none Details | Review

Description dorrin 2006-03-24 19:10:22 UTC
This patch modifies EOG to use the GOption system, rather than Popt.
Comment 1 dorrin 2006-03-24 19:11:09 UTC
Created attachment 61938 [details] [review]
Patch to convert EoG to GOption
Comment 2 Michael Plump 2006-03-24 19:25:08 UTC
Created attachment 61939 [details] [review]
Patch to make eog use goption

Uh, yeah, you were apparently doing this at the exact same time.  My patch is 90% the same, but it throws the option parsing into gnome_program_init, and supports help translation.

But, uh, it's pretty much the same.  I'm just attaching it because I have it, basically.
Comment 3 Lucas Rocha 2006-03-27 00:36:58 UTC
I'll stay with Michael's patch, ok? Thanks for the report and patches guys.

2006-03-26  Lucas Rocha  <lucasr@gnome.org>

        GOption migration (Fixes bug #335877). Patch from Michael
        Plump <plumpy@skylab.org>

        * configure.in: remove popt dependencie.
        * src/main (main, handle_cmdline_args): use GOption instead of popt.