After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335874 - [PATCH] Port to goption
[PATCH] Port to goption
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-24 18:30 UTC by Don Scorgie
Modified: 2006-03-30 12:42 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Move to goption framework (3.43 KB, patch)
2006-03-24 18:30 UTC, Don Scorgie 		committed Details | Review

Description Don Scorgie 2006-03-24 18:30:04 UTC 
Please describe the problem:
Since all the cool kids are doing it...

Attached (in a second) is a patch to move yelp to the goption framework.

Comments?

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Don Scorgie 2006-03-24 18:30:43 UTC 
Created attachment 61936 [details] [review]
Move to goption framework
Comment 2 Christian Persch 2006-03-25 11:45:58 UTC 
You should add a g_object_unref (program) right before the end of main(), as to not leak the program.
Comment 3 Luis Menina 2006-03-25 14:21:07 UTC 
The example 2 at http://developer.gnome.org/doc/API/2.0/libgnome/libgnome-gnome-program.html#gnome-program-init
should then be changed, as this comportment is not highlighted. There's no g_object_unref call in the example.
Comment 4 Brent Smith (smitten) 2006-03-26 22:17:10 UTC 
DonS: I've tested here, and it seems to work fine.  Can we make the changes chpe mentions in comment 2 and commit to HEAD?
Comment 5 Don Scorgie 2006-03-30 11:34:47 UTC 
Patch committed with chpes modification.  Closing.
Comment 6 Christian Persch 2006-03-30 12:42:38 UTC 
I just noticed another thing: "with-cache-dir" should be G_OPTION_ARG_FILENAME, not STRING. But it seems unused, maybe it should just be removed.