GNOME Bugzilla – Bug 335814
"logical" hebrew encoding is called "visual" in menu
Last modified: 2013-09-13 00:52:39 UTC
Please describe the problem: In View->Character encoding, there's an entry for "Hebrew Visual iso-8859-8" but when you use it you see that it's actually Logical encoding (iso-8859-8-i) by the fact that messages with logical encoding are displayed correctly. Apparently the label is wrong. This can be confusing for users looking for the correct encoding. I suggest that the label for this entry will be changed to "Hebrew, Logical (ISO-8859-8-i)". Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
see also bug 329694. so you state that it is called "logical" instead of "visual" (i have no clue at all about hebrew, that's why i asked)? can you explain why we should change "ISO-8859-8-i" to "ISO-8859-8"?
ok, so visual hebrew is 8859-8, and logical hebrew is 8859-8-i. forget my last comment.
http://article.gmane.org/gmane.linux.region.israel.ivrix.discuss/1147 : "There is exactly one buggy mailer that sends ISO-8859-8 as logical Hebrew: Evolution." so it seems that we also have to take a look at this for sending, not only for viewing. general information on logical vs visual can be found at http://people.w3.org/rishida/scripts/bidi/
I can't check it right now, but I guess that for sending this can be fixed simply by changing the relevant string (that describes the charset) from ISO-8859-8 to ISO-8859-8-i (maybe lowercase). Perhaps that's the same string that should be fixed for viewing.
Created attachment 73542 [details] [review] Submitting patch that makes the required changes.
ushveen, what does the patch fix? only viewing, or also sending?
The patch fixes viewing,have not checked for sending.
Andre: The same patch would also fix sending.
Committed.
*sigh I committed this accidently with other i18n patches from Ushveen. this has been requested for freeze break. Should I revert it back?