After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335585 - xvidenc does not mark key-frame/delta-units
xvidenc does not mark key-frame/delta-units
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.1
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-22 22:20 UTC by Mark Nauwelaerts
Modified: 2006-05-03 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for some xvidenc fixes (1.33 KB, patch)
2006-03-22 22:28 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2006-03-22 22:20:57 UTC 
xvidenc does not mark/flag an outgoing encoded buffer as being a delta-unit or not, so a subsequent muxing element cannot record key-frame info (in e.g. index)
Comment 1 Mark Nauwelaerts 2006-03-22 22:28:09 UTC 
Created attachment 61801 [details] [review]
Patch for some xvidenc fixes

Patch to mark outgoing encoded buffers as delta-units (or not).
Note that this patch also patches:
- the setting of fincr and fbase in xvid-encoder creation based on caps framerate
- makes 0, rather than 2, the default max_b_frames, as the current xvidenc does not seem "fully prepared" to handle b-frame "effects", such as encoder returning 0 encoded bytes, etc
Comment 2 Wim Taymans 2006-03-23 09:15:36 UTC 
        Patch by: Mark Nauwelaerts <manauw at skynet dot be>

        * ext/xvid/gstxvidenc.c: (gst_xvidenc_init), (gst_xvidenc_setup),
        (gst_xvidenc_chain):
        Patch to mark outgoing encoded buffers as delta-units (or not).
        Note that this patch also patches:
        - the setting of fincr and fbase in xvid-encoder creation based on
          caps framerate
        - makes 0, rather than 2, the default max_b_frames, as the current
          xvidenc does not seem "fully prepared" to handle b-frame
          "effects", such as encoder returning 0 encoded bytes, etc.
        Fixes #335585