After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335490 - Previous and next buttons initially disabled in shuffle mode
Previous and next buttons initially disabled in shuffle mode
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 335345 335774 337619 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-22 10:55 UTC by Tom Kirby
Modified: 2007-01-25 06:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.42 KB, patch)
2006-03-22 12:29 UTC, James "Doc" Livingston 		committed Details | Review

Description Tom Kirby 2006-03-22 10:55:34 UTC 
Please describe the problem:
If shuffle is turned on when RB starts, the "previous" and "next" buttons are
disabled.

Steps to reproduce:
1. Turn on shuffle
2. Quit RB
3. Start RB again and play a song


Actual results:
Previous and next buttons are disabled.

Expected results:
Previous and next buttons enabled.

Does this happen every time?
Yes.

Other information:
I just switched the toolbar mode to "text beside icons" before I updated to
latest CVS, in case this might have something to do with it. If I switch back,
the problem persists.
Comment 1 Tom Kirby 2006-03-22 10:56:13 UTC 
If I toggle shuffle off and then on, the buttons work again.
Comment 2 Alex Lancaster 2006-03-22 11:16:32 UTC 
See this problem too.  Confirming.  Noticed when I went into the DAAP source for the first time.
Comment 3 James "Doc" Livingston 2006-03-22 12:29:55 UTC 
Created attachment 61759 [details] [review]
patch

Te "have next/previous changed" isn't getting called for some cases (such as when you first start playing from a source). This patch fixes it for me.
Comment 4 Alex Lancaster 2006-03-24 08:40:36 UTC 
*** Bug 335774 has been marked as a duplicate of this bug. ***
Comment 5 Alex Lancaster 2006-03-24 08:41:38 UTC 
(In reply to comment #3)
> Created an attachment (id=61759) [edit]
> patch
> 
> Te "have next/previous changed" isn't getting called for some cases (such as
> when you first start playing from a source). This patch fixes it for me.

Works for me.  Also fixes bug #335774 (which is when you are in "loop" mode).
Comment 6 James "Doc" Livingston 2006-03-24 09:09:37 UTC 
Committed to cvs. I think this should fix all the cases where we weren't updating previous/next availability, but if it doesn't feel free to re-open the bug.
Comment 7 James "Doc" Livingston 2006-03-25 12:07:10 UTC 
*** Bug 335345 has been marked as a duplicate of this bug. ***
Comment 8 James "Doc" Livingston 2006-04-08 05:23:41 UTC 
*** Bug 337619 has been marked as a duplicate of this bug. ***
Comment 9 James "Doc" Livingston 2006-04-19 10:19:48 UTC 
This seems to be occurring again. It's reproducable:

1) turn shuffle on and repeat off
2) double click on the first track
3) press next
4) press previous

After these steps, the previous button should be disabled because there is not previous track, but it isn't. If you then press the previous button it will stop because rb_play_order_get_previous returns NULL.
Comment 10 Matti Lindell 2007-01-24 22:33:49 UTC 
This bug is fixed in HEAD, probably since 0.9.5.
Comment 11 James "Doc" Livingston 2007-01-25 06:04:36 UTC 
Marking FIXED, as per previous comment.