After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335231 - [wavparse] incorrect way to calculate seek position with block alignment
[wavparse] incorrect way to calculate seek position with block alignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.2
Other All
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-20 14:56 UTC by Tommi Myöhänen
Modified: 2006-03-21 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gstwavparse to fix block aligning problem (765 bytes, patch)
2006-03-20 14:58 UTC, Tommi Myöhänen 		committed Details | Review

Description Tommi Myöhänen 2006-03-20 14:56:53 UTC 
Please describe the problem:
This bug is related to bug #326864. For audio formats that use block aligning, 
seek position might be calculated incorrectly in wavparse element. The "wav->
offset" is added by "wav->datastart" value, and the block alignment modulo 
calculation is performed after this. in certain conditions this causes the 
offset to become zero.

I attached a minimalistic patch that fixes this by changing the order of these 
operations :)


Steps to reproduce:



Actual results:



Expected results:



Does this happen every time?



Other information:
Comment 1 Tommi Myöhänen 2006-03-20 14:58:12 UTC 
Created attachment 61623 [details] [review]
Patch for gstwavparse to fix block aligning problem
Comment 2 Tim-Philipp Müller 2006-03-21 13:08:47 UTC 
Thanks - committed:

 2006-03-21  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Tommi Myöhänen  <ext-tommi dot myohanen at nokia dot com>

       * gst/wavparse/gstwavparse.c: (gst_wavparse_perform_seek):
         Fix block alignment calculation. Alignment should be done before
         adding the byte offset where the data starts (#335231).