After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335112 - Errors in use of ellipsis (...) in menu items
Errors in use of ellipsis (...) in menu items
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.23.x
Other All
: Normal minor
: 2.24.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-19 12:11 UTC by Matthew Paul Thomas (mpt)
Modified: 2008-05-09 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for the above problems (3.58 KB, patch)
2006-09-01 23:23 UTC, Stephen Cook
none Details | Review
updated patch (4.31 KB, patch)
2008-05-09 14:51 UTC, Cosimo Cecchi
committed Details | Review

Description Matthew Paul Thomas (mpt) 2006-03-19 12:11:18 UTC
Version 2.12.1, Ubuntu 5.10

Three Nautilus menu items do not follow the HIG guidelines on using ellipses <http://developer.gnome.org/projects/gup/hig/2.0/menus-design.html#menu-item-type-command>.

*   "Stretch Icon..." does not have an ellipsis and should. The usual goal
    when selecting this item is stretching the icon, and that does not
    happen without further input.

*   "Share [F]older..." does not have an ellipsis and should. The usual goal
    when selecting this item is sharing the folder, and that does not happen
    without further input.

*   "Edit Bookmarks..." does not have an ellipsis and should. The usual goal
    when selecting this item is changing the bookmarks in some way, and that
    does not happen without further input.
Comment 1 Christian Neumair 2006-03-19 13:32:15 UTC
Thanks for your bug report!

Your proposals sound reasonable, this is still an issue with Nautilus 2.14, milestoning to 2.16.
Comment 2 Christian Neumair 2006-07-10 15:58:54 UTC
Regarding "Select Pattern", you also pointed out

> *   The menu item should end with an ellipsis, because the usual
>      intended task (selecting some items) requires more input.
> 
> *   "Select Pattern" is unhelpful. It's not for selecting a pattern,
>      it's for selecting items that match a pattern. Perhaps "Select
>      Items Matching…"

on usability list. Alex is on vacation, and tomorrow we'll be string frozen for Nautilus 2.16 :/.
Comment 3 Stephen Cook 2006-09-01 23:23:04 UTC
Created attachment 72051 [details] [review]
patch for the above problems

This patch fixes the above problems apart from share folder which is in a different package I believe.
Comment 4 Joachim Noreiko 2007-03-15 14:52:01 UTC
Please remember to notify the docs team when this is applied (either reassign this bug, or file a new one).

(Oh yeah, and *bump* ;)
Comment 5 Cosimo Cecchi 2008-05-09 14:51:38 UTC
Created attachment 110645 [details] [review]
updated patch

I updated the patch to apply to trunk, I think we should commit this now, before any kind of 2.23 freeze.
Comment 6 Cosimo Cecchi 2008-05-09 16:11:38 UTC
Committed, closing as FIXED.

2008-05-09  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/file-manager/fm-directory-view.c: (select_pattern):
	* src/file-manager/fm-icon-view.c:
	* src/nautilus-navigation-window-menus.c:
	* src/nautilus-spatial-window.c:
	Ellipsize and HIG-ify some menu items. (#335112).