After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 335032 - [PATCH] Use GOption instead of popt
[PATCH] Use GOption instead of popt
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks: 320390
 
 
Reported: 2006-03-18 17:42 UTC by Paolo Borelli
Modified: 2006-05-09 06:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.14 KB, patch)
2006-03-18 17:43 UTC, Paolo Borelli
needs-work Details | Review

Description Paolo Borelli 2006-03-18 17:42:20 UTC
what the summary says.

It will also fix bug 320390
Comment 1 Paolo Borelli 2006-03-18 17:43:37 UTC
Created attachment 61508 [details] [review]
patch
Comment 2 Christian Persch 2006-03-25 22:58:04 UTC
While you're at it, you should add g_object_unref(program) after gtk_main() before the end of main(), and g_strfreev the remaining_args :)
Comment 3 Sebastien Bacher 2006-03-27 09:11:51 UTC
"context = g_option_context_new ("");", shouldn't a comment be used?

"description = g_strdup_printf ("- %s", _("Directly edit your entire configuration database"));
context = g_option_context_new (description);
g_free (description);"

if you want to use the Comment= from the .desktop translated
Comment 4 Kristof Vansant 2006-04-23 22:18:56 UTC
I also made a patch(see #320390). which is best? :)
I like to introduce --key foo
so we can add extra options in the future 

Comment 5 Kjartan Maraas 2006-05-07 10:50:22 UTC
Marking needs-work based on Christian's comments.
Comment 6 Fernando Herrera 2006-05-09 06:21:03 UTC
Thanks for the patch. I applied a mix of them.

2006-05-09  Fernando Herrera  <fherrera@onirica.com>

        * configure.in:
        * src/main.c: (main): Port to GOption. Patches and code from
        Paolo Borelli, Christian Persch and Kristof Vansant. Fixes
        bugs #335032 and #320390.