After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334963 - External Tools configuration does not instant apply
External Tools configuration does not instant apply
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-18 09:45 UTC by Steve Frécinaux
Modified: 2019-03-23 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Apply Paolo's idea for auto-apply (2.40 KB, patch)
2006-03-18 13:38 UTC, Steve Frécinaux
committed Details | Review

Description Steve Frécinaux 2006-03-18 09:45:54 UTC
You have to close the external tools manager for the changes to be applied, which can be annoying when you want to try out your tool.

On the other hand the dialog layout only provides a close button instead of a apply/cancel combo.

NB. There is a really simple fix but it's ugly and not efficient at all since the current way of updating the menu is to remove it entirely and recreate it.
Comment 1 Paolo Maggi 2006-03-18 10:17:43 UTC
Could you describe the simple fix you are thinking about?
Comment 2 Steve Frécinaux 2006-03-18 10:31:13 UTC
The simple fix consists on updating the menu (ie destroying it and creating it again) everytime the tools tree is updated. It is not perfect though, because the tree is not updated everytime you move focus from one widget to another.

Currently the XML tree is updated when you click on a tool in the left-hand side list.
Comment 3 Paolo Maggi 2006-03-18 11:49:32 UTC
What about updating the menu when the dialog looses the focus?

We should also check the case an accellerator is used to activate a tool and the focus is on the dialog. I'm quite sure this will not be a problem since the main window will not get the accellerator and so it should not be possible to activate a tool using the accellerator without first moving the focus out of the dialog, but I may be wrong.
Comment 4 Steve Frécinaux 2006-03-18 13:38:00 UTC
Created attachment 61485 [details] [review]
Apply Paolo's idea for auto-apply

This patch applies the idea provided by Paolo Maggi. This needs some further testing.

I just noticed some glitches about the accelerators which are not always correctly updated (but this is also the case without the patch). I think it comes from GTK way to set custom accelerators.
Comment 5 Paolo Borelli 2006-03-19 10:26:15 UTC
The patch looks fine to me. I see the accel problem, but I don't see how it has anything to do with this patch. It's a separate problem which needs investigation.

I say to put the patch in.
Comment 6 Steve Frécinaux 2006-03-19 10:51:37 UTC
The patch has been committed.

I don't close the bug yet so that I'll be able to implement autoapply more nicely. Ideally only the menus that have changed should be updated.
Comment 7 Steve Frécinaux 2006-11-20 10:58:57 UTC
Closing this bug as there is no really better way to handle this issue than the current one.