GNOME Bugzilla – Bug 334947
gnome-background-properties uses a "Finish" button instead of "Close"
Last modified: 2006-03-22 15:25:43 UTC
Please describe the problem: As specified in the HIG, instant apply dialogs should feature a "Close" button. g-b-p also features such a button, but it's labelel "Finish" and uses a checked mark for it'sicon. The label should be close, the icon should be the "close" icon. Steps to reproduce: 1. Open gnome-background-properties 2. Stare and wonder Actual results: Expected results: Does this happen every time? Other information:
Created attachment 61468 [details] gnome-background-properties how it is now
Created attachment 61469 [details] gnome-background-properties how the button should really look like
confirming for 2.14.0, this seems to be inconsistent with the rest of the desktop.
This is not changing. Yes, it does say Finish. Yes, all the other capplets say Close. Yes, it is now Finish as a result of direct usability testing, of the capplet, and other capplets should be changing for 2.16 to "Finish" or something more appropriately affirmitive for their actions. This change has been in for over one month, so I'm not about to change it after 2.14.0 has happened already. Also, I just looked at the HIG section on instant-apply windows at http://developer.gnome.org/projects/gup/hig/2.0/windows-utility.html and it clearly does not mention a "Close" button at all. "Close" and the "X" close icon don't actually tell anything to the user. In user testing, the one thing that continually came up with people using instant apply dialogs, was that they were unsure whether the settings were going to stick. "Close" means go away. "Finish" means "I am done", to the user.
Instead of closing NOTABUG, shouldn't the bug be changed to it's inverse: All capplets should have a Finish button instead of a Close button. Additionally, if usability testing has established that a button named "Finish" is the right way to go, should we consider amending the HIG to reflect this.
It would have been nice to change all of these at once, instead of introducing an inconsistency in the desktop. Agreeing with comment 7: all other pref tools need to change.