After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334934 - test-ve-config does not build in certain circumstances
test-ve-config does not build in certain circumstances
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.14.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-17 22:03 UTC by Dmitry V. Levin
Modified: 2006-03-21 01:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Makefile.am.diff (711 bytes, patch)
2006-03-17 22:05 UTC, Dmitry V. Levin 		none Details | Review
Makefile.am.diff (498 bytes, patch)
2006-03-21 01:00 UTC, Dmitry V. Levin 		none Details | Review

Description Dmitry V. Levin 2006-03-17 22:03:44 UTC 
In gdm-2.14.0, the test program for vicious-extensions (test-ve-config) fails to build if glib&Co libraries are available only in static form, or --as-needed linker option is used:

gcc -O2 -Wall -Wmissing-prototypes -o test-ve-config test-ve-config.o -lglade-2.0 -lgtk-x11-2.0 -lxml2 -lz -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0 ../vicious-extensions/libvicious.a
../vicious-extensions/libvicious.a(ve-config.o): In function `free_line':ve-config.c:(.text+0x60): undefined reference to `g_free'
:ve-config.c:(.text+0x72): undefined reference to `g_free'
:ve-config.c:(.text+0x81): undefined reference to `g_free'
and so on.
Comment 1 Dmitry V. Levin 2006-03-17 22:05:32 UTC 
Created attachment 61463 [details] [review]
Makefile.am.diff

Proposed fix.
Comment 2 Brian Cameron 2006-03-20 23:51:23 UTC 
I'm not sure how to fix this.  I think GDM just depends on pkg-config to return the correct linker/compile options to glib&co, so perhaps these aren't set right on your machine to build with static libraries?  Not sure.

If the problem is with GDM's Makefile's or such, I'd accept a patch that would fix this problem (assuming it doesn't break the build when linking against non-static libraries).
Comment 3 Brian Cameron 2006-03-20 23:54:55 UTC 
Oh, sorry, I totally missed the proposed patch you attached.  I see it now, and just applied it to CVS head.  Looks good.  Thanks.
Comment 4 Dmitry V. Levin 2006-03-21 01:00:38 UTC 
Created attachment 61652 [details] [review]
Makefile.am.diff

Oops, there is a typo (missing backslash) in the patch I submitted.
The patch I actually tested was made for 2.14.0.
Comment 5 Brian Cameron 2006-03-21 01:08:17 UTC 
Thanks for catching this.  This is now fixed again in CVS.