After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334860 - Weird "x-nautilus-desktop" in the Places menu
Weird "x-nautilus-desktop" in the Places menu
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.14.x
Other All
: Normal normal
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
: 330594 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-17 11:06 UTC by Priit Laes (IRC: plaes)
Modified: 2006-04-14 11:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
x-nautilus-desktop-wtf.png (81.39 KB, image/png)
2006-03-17 11:07 UTC, Priit Laes (IRC: plaes)
  Details
Proposed patch (817 bytes, patch)
2006-03-17 11:32 UTC, Christian Neumair
accepted-commit_now Details | Review

Description Priit Laes (IRC: plaes) 2006-03-17 11:06:17 UTC
Please describe the problem:
I have a weird x-nautilus-desktop menu entry in Places menu.
Clicking on it opens ~/Desktop directory, but the title of the new nautilus
window is still x-nautilus-desktop.

I'm using Nautilus-2.14.0

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Screenshot coming...
Comment 1 Priit Laes (IRC: plaes) 2006-03-17 11:07:23 UTC
Created attachment 61427 [details]
x-nautilus-desktop-wtf.png
Comment 2 Christian Neumair 2006-03-17 11:20:14 UTC
Thanks for your bug report!

The location you are displaying is "x-nautilus-desktop:///", i.e. the special location of the desktop. It contains your volumes, some special links and everything in ~/Desktop. You probably pressed ctrl-D on the desktop and accidentally bookmarked it. Let's block that accelerator.
Comment 3 Christian Neumair 2006-03-17 11:32:51 UTC
Created attachment 61431 [details] [review]
Proposed patch

Discussion under

http://mail.gnome.org/archives/nautilus-list/2006-March/msg00075.html
Comment 4 Arthur Taylor 2006-03-19 01:30:27 UTC
If you browse to the location of the desktop, "x-nautilus-desktop" also shows up in nautilus' history list.
Comment 5 Christian Neumair 2006-03-19 10:42:13 UTC
Arthur: I'd like to keep that behavior, because it is correct. Users are not supposed to browse to "x-nautilus-desktop:///", and we can use it for debugging purposes.
Comment 6 Arthur Taylor 2006-03-19 20:08:56 UTC
Opps, sorry, I thought 'x-nautilus-desktop' was showing up in nautilus's history if I browsed to the location of the desktop (/home/user/Desktop), but it doesn't. My bad.
Comment 7 Christian Neumair 2006-03-20 15:48:10 UTC
Patch was commmitted, closing.
Comment 8 Christian Neumair 2006-03-24 12:19:42 UTC
*** Bug 330594 has been marked as a duplicate of this bug. ***
Comment 9 Baptiste Mille-Mathias 2006-04-13 19:05:05 UTC
The patch seems not have been commited as I still see the same bug in 2.14.1
Comment 10 Martin Wehner 2006-04-13 19:25:51 UTC
It was commited but if you have an existing bookmark, it won't go magically away. You can't just accidentily bookmark the desktop anymore.
Comment 11 Baptiste Mille-Mathias 2006-04-13 19:30:05 UTC
The problem is I just tested to do a ctrl+D on the desktop and it bookmarked x-nautilus-desktop. I didn't had the bookmark before.
I'm using nautilus 2.14.1
Comment 12 Christian Neumair 2006-04-13 21:36:50 UTC
Setting patch status to accepted-commit_now because it wasn't committed (the ChangeLog claims it was, though). Sorry, it was my fault. I'm not on a box with CVS access ATM so I can't commit it myself, maybe you could do it Martin?
Comment 13 Martin Wehner 2006-04-14 11:58:43 UTC
So, it's in now:

2006-04-14  Martin Wehner  <martin.wehner@gmail.com>

	* src/nautilus-spatial-window.c: (action_add_bookmark_callback):
	Don't add location bookmark for desktop windows. Fixes #334860.

	Patch from Christian Neumair <chris@gnome-de.org>