GNOME Bugzilla – Bug 334829
Regressions in stream playback from 0.8.x
Last modified: 2018-05-24 11:29:45 UTC
Playing back streams in Rhythmbox 0.9.3.1 with Gstreamer 0.10 seems to suffer from some regressions from the 0.8.x series. The following streams (from the default playlist) does not play in 0.9.3 but works fine in 0.8.8: Digitally Imported Digitally Imported Deep House Digitally Imported Trance Indie Pop Rocks Proton Radio Radio Paradise These two seems to be dead and should be removed and/or updated: AfterhoursDJ.org (hangs Rhythmbox (both 0.9.3.1 and 0.8.8)) Bluemars Also, it is not possible to pause streams using the middle mouse button on the panel applet or using 'rhythmbox --play-pause'. Using Rhythmbox 0.9.3.1 with Gstreamer plugins base 0.10.3 and good/ugly 0.10.2 on Debian sid.
I discovered that Totem (with xine backend) had similar problems, guess this is a gnome-vfs bug. http://bugzilla.gnome.org/show_bug.cgi?id=334831
iradio error reporting is a bit broken at the moment, so sometimes it's hard to tell what's actually going on. iradio as a whole is a bit broken, really. The problems with proton radio and radio paradise are probably caused by bugs in the version of totem-plparser you're using - switching from totem 1.2.1 (debian packages) to totem CVS fixed these for me. Bluemars works for me, but afterhoursdj.org does seem to be dead. The site itself seems to have become a search engine portal/domain squatting type thing, so I guess we should remove that from the list. The remaining problems seem to be caused by AOL's streaming servers being picky about which clients they're willing to talk to. They mostly work for me, using gstreamer 0.10 cvs with some patches (bug 333657 and bug 325847). They should work about as well with gstreamer 0.8 as is.
AfterhoursDJs.org still seems to be around, but their stream has changed URL to http://afterhoursdjs.org/ahdjs192.m3u
I've changed the AfterHours DJs address in cvs. The whole radio playing and reporting stuff is fairly messy. What I think would be much nicer would be if there was a gstreamer element which handled streams of type m3u/pls/etc. The element would be a bin that could consume that stream by sending it to totem-plparser and storing the resulting uris. It could use gst_element_make_from_uri to make a new source element and ghost it's output the the bin's source pad. When that element EOS'd, the bin would create a new source element for the next URI and ghost that to the bin's source pad. In any case, I think the playlist parsing stuff should be moved from the shell-player to the player backend, and we need to make it properly cancel the playlist parsing if it hasn't finished when the player gets told to close/change uris.
as a note, another idea would be to parse the playlists in gstreamer and post a message to add the specific url(s) to the playlist.
That would probably be much easier from the gstreamer side, and wouldn't be much harder from the app side. Just have the shell-player maintain an internal "playlist" which gets filled by those messages, and when it receives EOS play the next URI in the list, doing our normal EOS stuff when empty.
This plugin could maybe be developed on top of of Totems playlist library? That library is LGPL so it wouldn't clash with GStreamers licensing.
I tried a more recent cvs snapshot with version 1.4.0 of libtotem-plparser, and now all my streams play without problems. I still can't pause streams using middle mouse button on the panel applet or with --play-pause, maybe I should file this separately?
Sven: that's been fixed in cvs (I can't find the bug number at the minute)
Was that fix included in the latest release? Because I'm still having trouble pausing streams in 0.9.4.
Created attachment 64256 [details] [review] patch This patch removes the the last bit of code that causes that. I think that removing the parameter to rb_shell_player_playpause would break the dbus interface, so I haven't.
That makes the applet and --play-pause work for me, but breaks the normal pause button.
The changes to call rb_shell_player_play instead of _playpause cause various weird behaviour, as _play just starts playing the most recently opened entry. When switching sources, for example, this can mean an entry that is not present in the new source starts playing. It also causes the pause button to not do anything.
*** Bug 343134 has been marked as a duplicate of this bug. ***
Created attachment 66358 [details] [review] updated patch I inadvertantly fixed this for the tray icon as part of bonobo removal. This patch deprecates the 'ignore-stop' option to rb_shell_player_playpause.
Looks good to me, except I'd change the Python binding to the following so that you don't have to pass it from Python. @@ -387,7 +387,7 @@ (c-name "rb_shell_player_playpause") (return-type "gboolean") (parameters - '("gboolean" "ignore_stop") + '("gboolean" "unused" (default "FALSE")) '("GError**" "error") ) )
Good point. Committed with that change. Since there's still the idea of a gstreamer playlist parser element, we might as well leave this bug open for it. Implementing such a thing would be, um, interesting.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/167.