After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334697 - interesting behaviour of scatterplot in presence of missing data
interesting behaviour of scatterplot in presence of missing data
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Emmanuel Pacaud
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-03-15 22:24 UTC by Andreas J. Guelzow
Modified: 2006-04-05 06:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screen shot (10.43 KB, image/png)
2006-03-15 22:24 UTC, Andreas J. Guelzow
  Details
gnumeric sample file (2.28 KB, application/octet-stream)
2006-03-15 23:02 UTC, Andreas J. Guelzow
  Details
proposed patch (5.76 KB, patch)
2006-03-18 14:26 UTC, Jean Bréfort
none Details | Review
updated patch (9.51 KB, patch)
2006-03-20 09:35 UTC, Jean Bréfort
none Details | Review
new updated patch (9.61 KB, patch)
2006-03-29 11:44 UTC, Jean Bréfort
none Details | Review
the same with invalid-as-zero (9.62 KB, patch)
2006-04-05 06:29 UTC, Jean Bréfort
committed Details | Review

Description Andreas J. Guelzow 2006-03-15 22:24:18 UTC
please see the attached image. I would have expected some more obvious behaviour for missing values, eg. dropping them or setting them to 0.
Comment 1 Andreas J. Guelzow 2006-03-15 22:24:56 UTC
Created attachment 61321 [details]
screen shot
Comment 2 Jody Goldberg 2006-03-15 22:33:46 UTC
That is definitely unexpected.  Please tack on a sample file just in case there are some magic settings somewhere.
Comment 3 Andreas J. Guelzow 2006-03-15 23:02:55 UTC
Created attachment 61324 [details]
gnumeric sample file
Comment 4 Jean Bréfort 2006-03-16 12:40:29 UTC
Hmm, if y==NAN, we use y=0 and if x==NAN, we use the index.
if (!gog_axis_map_finite (y_map, y))
	y = 0; /* excel is just sooooo consistent */
if (!gog_axis_map_finite (x_map, x))
	x = i;
So, the result is logical if not wanted. We clearly must use something more consistent.
Comment 5 Andreas J. Guelzow 2006-03-16 13:43:06 UTC
"if y==NAN, we use y=0" is not unexpected and some users may in fact want this. I would prefer if the user had a choice between this behaviour and excluding that point from the graph.

"if x==NAN, we use the index" I can't imagine any user really wanting this unless no x value range is given at all. It would be less surprising to use 0 for missing values but again it would be nice if we had a choice.

So, personally, using index (rather than 0) is a bug. Having a choice is an enhancement request. 
Comment 6 Jean Bréfort 2006-03-16 14:33:48 UTC
Hide points, with 0 as an option seems the best choice. Anyway, when drawing lines these points are excluded.
Comment 7 Jean Bréfort 2006-03-18 14:26:03 UTC
Created attachment 61489 [details] [review]
proposed patch
Comment 8 Emmanuel Pacaud 2006-03-20 08:50:01 UTC
I think you should use glade for user interface. We'll probably add other settings to it.

Also, could you adjust widget layout in order to fit existing dialogs.
Comment 9 Jean Bréfort 2006-03-20 09:35:17 UTC
Created attachment 61600 [details] [review]
updated patch

The same, but using libglade
Comment 10 Emmanuel Pacaud 2006-03-29 09:23:34 UTC
Looks ok for me, except for the fact GladeXML is not freed in 
gog_xy_series_populate_editor.
Comment 11 Jean Bréfort 2006-03-29 11:44:34 UTC
Created attachment 62292 [details] [review]
new updated patch

Emmanuel, you are right, this patch should solve this problem.
Comment 12 Morten Welinder 2006-04-04 19:27:52 UTC
Can we change the name to invalid-as-zero, please?  Other than that, go
ahead and commit.
Comment 13 Jean Bréfort 2006-04-05 06:29:53 UTC
Created attachment 62776 [details] [review]
the same with invalid-as-zero
Comment 14 Jean Bréfort 2006-04-05 06:47:38 UTC
commited. fixed in HEAD