GNOME Bugzilla – Bug 334674
Support for Motorola iTunes ROKR
Last modified: 2006-05-06 15:25:29 UTC
I want to send informations about the mobile phone called ROKR, with Itunes. I hope that in the future I can sync my phone using Rhythmbox ;-) Phone: Motorola Itunes ROKR hal storage.model: Motorola Phone Once it is sync with iTunes, it creates a iTunes folder, with some files that I want to atach. (the songs will be left out ;-))
Created attachment 61311 [details] iTunes database from Rokr This is the compressed iTunes folder from the phone TransFlash card, created by iTunes from Windows.
I think libgpod will handle that phone in the future. All rhythmbox needs to do is to detect this phone as an iPod (ie the hal detection needs to take it into account).
I think not, the iTunesDB file from phone is different from the iPod. I tried to sync my phone with gtkpod, moving the files to correct places into the phone, but didn't works. The iPod has almost the same folder structure then the phone, except by the main folder, that's called iTunes_Control into the phone. I'm helping YamiPod (with information and tests) to support this phone, it's almost working.
So YamiPod can get support for this phone, but libgpod won't be able to get support for that phone for whatever reason ??? For what it's worth, here is what was committed to libgpod CVS this week-end... « * itdb.h, itdb_itunesdb.c, itdb_private.h: added support for mobile phone reversed-endian iTunesDB. »
Correcting something, YamiPod 0.94 finally supports Motorola ROKR Phone ;-) I want Rhtyhmbox support for ROKR, if I didn't, why I'm submitting this bug? All my songs are under Rhytmbox database ;-) Rhythmbox needs YOU! http://gnomedesktop.org/node/2609
Yep, and my initial comment in this bug report was just describing the amount of work that will have to be done to achieve that goal, ie there are only a few lines to change, and if libgpod CVS is installed, everything should be ok.
Hmm, in hal you don't have anything more specific than Motorola Phone? I guess this string can be found on non-ROKR motorola phones?
Using the USB ID to match the phone would be a better idea than its name. Could you attach the output of lshal to this bug?
Created attachment 61377 [details] lshal from my machine This is the lshal from my machine with Rokr connected.
Created attachment 63998 [details] SLVR phone lshal output Motorola SLVR phone also supported. Attaching lshal w/ SLVR connected to get it's ids.
Created attachment 64833 [details] [review] preliminary patch The attached patch at least lets rb read from the db on a mobile phone if you have libgpod > 0.3.3. haven't tried syncing... can someone look over this and comment on it? i'm sure it has some issues, as it prints out the following messages: 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message 2362: arguments to dbus_message_new_method_call() were incorrect, assertion "path != NULL" failed in file dbus-message.c line 793. This is normally a bug in some application using the D-BUS library. libhal.c 1203 : Couldn't allocate D-BUS message
Created attachment 64885 [details] [review] fix bad dbus usage errors don't try to get properties if the spider_udi is NULL
Thanks for working on this. I've committed it to cvs, with a small fix so that it compiles with older versions of libgpod. 2006-05-06 James Livingston <doclivingston@gmail.com> patch by: Joe Barnett <thejoe@gmail.com> * configure.ac: check if we're using a version of libgpod that supports the Motorola ROKR * sources/rb-ipod-source.c: (rb_ipod_get_itunesdb_path): ask libgpod for the db path, if we using the newer version. (rb_ipod_volume_has_ipod_db): detect Motorola ROKR phones.
awesome, thanks for looking at this. I haven't had a chance to check it out yet, but it looks like it will fail to compile (missing a } before the last #endif around line 707 of rb-ipod-source.c)...