GNOME Bugzilla – Bug 334647
gdmsetup missing in the menu
Last modified: 2006-04-17 21:58:07 UTC
Please describe the problem: In /usr/share/applications/gdmsetup.desktop 2.14.0 we have Categories=GNOME;Application;System;Settings; Both System and Settings categories implies that gdmsetup will not be shown in any menu. (see applications.menu and preferences.menu) solution, remove System category. In gdm 2.8.0.7, there wasn't the System category, and it worked fine. Moreover, Application category is not a registred feedesktop.org category. It should be removed in all GNOME apps. So finally, we should have this: Categories=GNOME;GTK;Settings; Second problem By default, gdmsetup is installed in /usr/sbin/ The problem is that /usr/sbin is not in the PATH for simple user in some distribution (Linux From Scratch for example) And so gdmsetup will not appear in the menu because of the "TryExec=gdmsetup" line in /usr/share/applications/gdmsetup.desktop solution, remove this line or put TryExec=/usr/bin/gdmsetup and what do you think to put by default: Exec=gksu gdmsetup ? Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? yes Other information:
Okay I fixed the code to use EXPANDED_SBINDIR/gdmsetup which will expand to /usr/sbin/gdmsetup, or if the user specifies a different sbindir via configure --sbindir, then this will just work okay. Distros that want to use gksu will need to hack the file to use this, though I would accept a patch to allow users to specify at configure time how they want this to work.
Created attachment 63562 [details] [review] fix generation of gdmsetup.desktop with all languages Your fix has broken the generation of gdmsetup.desktop with all the languages. You should have a gdmsetup.desktop.in.in file. You have to change your rule gdmsetup.desktop: $(srcdir)/gdmsetup.desktop.in sed -e 's,[@]sbindir[@],$(sbindir),g' <$(srcdir)/gdmsetup.desktop.in \ >gdmsetup.desktop by gdmsetup.desktop.in: $(srcdir)/gdmsetup.desktop.in.in sed -e 's,[@]sbindir[@],$(sbindir),g' <$(srcdir)/gdmsetup.desktop.in.in \ >gdmsetup.desktop.in I attached a patch.
Checked into CVS head. Thanks for the fix. A few comments. You should patch Makefile.am and not Makefile.in and re-run automake before running configure. Makefile.in is a generated file, so I had to move your fix to Makefile.am for you. Also, you didn't update the CLEANFILES variable in Makefile.am to ensure that the generated files get cleaned up. Also, you didn't updated System_in_files, used to make sure that EXTRA_DIST includes the right file to include in the distro. Take a look at the changes I made, and if you have any questions about how to do this, I'll be happy to help.
*** Bug 338629 has been marked as a duplicate of this bug. ***