After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334543 - untranslated text in titlebar of nautilus search window
untranslated text in titlebar of nautilus search window
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.14.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 334325 334650 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-14 14:44 UTC by Tino Meinen
Modified: 2006-03-18 07:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Proposed fix (729 bytes, patch)
2006-03-14 14:47 UTC, Wouter Bolsterlee (uws) 		none Details | Review
Better fix (43.92 KB, patch)
2006-03-14 15:07 UTC, Wouter Bolsterlee (uws) 		none Details | Review

Description Tino Meinen 2006-03-14 14:44:34 UTC 
Please describe the problem:
Once you've entered a searchterm and made the search, the title in window is no
longer translated and reads Search for %s.


Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Wouter Bolsterlee (uws) 2006-03-14 14:47:43 UTC 
Created attachment 61232 [details] [review]
Proposed fix

This patch marks the strings for translation.

And this should also be done: s/libgnome\/gnome-i18n/glib\/gi18n/
Comment 2 Wouter Bolsterlee (uws) 2006-03-14 15:07:01 UTC 
Created attachment 61234 [details] [review]
Better fix

Oops, forgot to add nautilus-query.c to POTFILES.in in the previous patch. Fixed in this version.

I've also replaced deprecated API with the correct #include:

find . -name '*.c' -exec sed -i -s 's/libgnome\/gnome-i18n/glib\/gi18n/' {} \;
Comment 3 Martin Wehner 2006-03-18 07:28:32 UTC 
Thanks, committed:

2006-03-18  Martin Wehner  <martin.wehner@gmail.com>

	* libnautilus-private/*.c:
	* src/file-manager/*.c:
	* src/*.c:
	Use gi18n.h instead of deprecated gnome-i18n.h header.

	* libnautilus-private/nautilus-query.c:
	(nautilus_query_to_readable_string):
	Mark string for translation.		

	* po/POTFILES.in:
	Add nautilus-query.c

	Patch from Wouter Bolsterlee <uws+gnome@xs4all.nl>
Comment 4 Martin Wehner 2006-03-18 07:32:24 UTC 
*** Bug 334650 has been marked as a duplicate of this bug. ***
Comment 5 Martin Wehner 2006-03-18 07:37:09 UTC 
*** Bug 334325 has been marked as a duplicate of this bug. ***