After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334540 - Do not show low disk space notification for read-only volumes
Do not show low disk space notification for read-only volumes
Status: RESOLVED FIXED
Product: gnome-volume-manager
Classification: Deprecated
Component: general
1.5.x
Other Linux
: Normal minor
: ---
Assigned To: Gnome volume manager maintainers
Gnome volume manager maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-14 14:36 UTC by Martin Pitt
Modified: 2006-03-14 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (995 bytes, patch)
2006-03-14 14:38 UTC, Martin Pitt 		none Details | Review

Description Martin Pitt 2006-03-14 14:36:14 UTC 
From https://launchpad.net/bugs/34618: It does not make much sense to display the warning for read-only mounts (which can happen for NTFS partitions, for example).

I attach the Ubuntu patch.
Comment 1 Martin Pitt 2006-03-14 14:38:33 UTC 
Created attachment 61230 [details] [review]
patch

The patch does two things:

- Use statvfs() instead of statfs() since the latter is deprecated (according to the manpage and LSB) and statvfs() additionally tells us mount flags.

- Do not notify about low disk space for read-only mounts.
Comment 2 Jeffrey Stedfast 2006-03-14 19:08:47 UTC 
this seems reasonable, but I'd rather not even add a device to the timeout if it is read-only (it's not going to be changing so no sense continuing to sttvfs() it)
Comment 3 Jeffrey Stedfast 2006-03-14 20:21:00 UTC 
fixed in a different way in CVS
Comment 4 Jeffrey Stedfast 2006-03-14 20:21:11 UTC 
fixed in a different way in CVS