After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334332 - String not marked for translation
String not marked for translation
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2006-03-12 17:30 UTC by Frank Arnold
Modified: 2006-03-13 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use _() on the string in question (680 bytes, patch)
2006-03-12 18:57 UTC, Thomas Thurman
committed Details | Review

Description Frank Arnold 2006-03-12 17:30:31 UTC
I've found a string accidentely not marked for translation.

File: src/window-props.c
Function: set_title_text
String: "%s (on %s)"

This is somehow urgent because it will be visible in our release notes
screenshots. Please inform gnome-i18n once it is done.
Comment 1 Thomas Thurman 2006-03-12 18:57:30 UTC
Created attachment 61137 [details] [review]
Use _() on the string in question

Is this what we need to do?
Comment 2 Frank Arnold 2006-03-12 20:22:22 UTC
Yes, for sure. Just to trivial to make a patch... ;)
Comment 3 Thomas Thurman 2006-03-12 20:27:03 UTC
I only just got CVS access, I'm not sure I'm allowed to patch things without asking the maintainers. Havoc/Elijah/anyone, okay to proceed? 
Comment 4 Elijah Newren 2006-03-12 20:48:22 UTC
Crap, I missed this in my review of bug 322202.  Thanks for catching it Frank.

Thomas, can you commit this to gnome-2-14 and HEAD and notify gnome-i18n that there was a string that we forgot to mark for translation?  We're kind of lucky in that very few will run across this, but Davyd put it in the release notes so this is still going to be a little embarassing when people look for it (and in particular for those translating the release notes and taking screenshots showing off the translation).

I was going to roll the metacity tarball today for 2.14.0 but I guess I'll wait a day to try to give translators more time.
Comment 5 Thomas Thurman 2006-03-12 21:28:16 UTC
Okay, great. I've committed it to gnome-2-14 and HEAD, and mailed gnome-i18n.
Comment 6 Thomas Thurman 2006-03-12 21:44:48 UTC
Oh, one other thing. Do I log this in ChangeLog even though it was such a minor change?
Comment 7 Frank Arnold 2006-03-12 23:12:41 UTC
(In reply to comment #4)
> Crap, I missed this in my review of bug 322202.  Thanks for catching it Frank.

Don't worry. Nautilus and gnome-control-center have similar issues. Davyd seemed to have bad luck while choosing release notes items... ;)
Comment 8 Elijah Newren 2006-03-13 16:01:55 UTC
(In reply to comment #6)
> Oh, one other thing. Do I log this in ChangeLog even though it was such a minor
> change?

I would.
Comment 9 Thomas Thurman 2006-03-13 17:49:59 UTC
done, then.