After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334303 - Stale libgnomeui check in configure
Stale libgnomeui check in configure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal minor
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-12 12:37 UTC by Julio Merino
Modified: 2006-03-12 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample patch. (911 bytes, patch)
2006-03-12 12:37 UTC, Julio Merino
committed Details | Review

Description Julio Merino 2006-03-12 12:37:15 UTC
gstreamer's configure script checks for the libgnomeui library.  This library was once used by one of the examples from the manual; see tests/old/examples/manual/Makefile.am.  Note that this code is in the tests/old subdirectory, so it is now unused (until someone adapts it to 0.10, if I understood it correctly).

In the meantime, I think that it'd be good if the extra "cruft" was removed.  This could allow confusion.  E.g., while packaging gstreamer 0.10 I saw that it needed this library and was tempted to make the package depend on libgnomeui.  Upon further inspection, I saw that this dependency was a "false positive".  Other people can be confused as well.

Furthermore, if this test is readded in the future, it'd be nice if it was done in a way that didn't force the whole gstreamer package to depend on libgnomeui.  After all, it is only used for a single example and is not needed at all to get gstreamer working.

Summarizing: configure.ac shouldn't check for libgnomeui.
Comment 1 Julio Merino 2006-03-12 12:37:36 UTC
Created attachment 61125 [details] [review]
Sample patch.
Comment 2 Tim-Philipp Müller 2006-03-12 14:33:08 UTC
Applied, thanks!

2006-03-12  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Julio M. Merino Vidal <jmmv at netbsd org>

       * configure.ac:
         Don't check for libgnomeui (leftover from old examples
         that aren't built or disted any longer) (#334303).