After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 334257 - Protected sheets are not saved into .gnumeric
Protected sheets are not saved into .gnumeric
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Main System
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-03-11 21:51 UTC by Klokan Petr Pridal
Modified: 2006-03-13 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Worksheet protection saved/read support for .gnumeric + dialog repaired. (4.21 KB, patch)
2006-03-11 22:05 UTC, Klokan Petr Pridal 		none Details | Review

Description Klokan Petr Pridal 2006-03-11 21:51:50 UTC 
Please describe the problem:
Each sheet have a posibility to be protected (locked against changes). Gnumeric
has GUI for setting that (either through Format->Sheet->Manage Sheets... or
Format->Cells[Protection]). This functionality is not correctly saved and again
loaded from file.

Steps to reproduce:
1. Set protection on some sheet(s)
2. Save workbook as Gnumeric file
3. Open such file

Actual results:
Protection on sheet(s) disappear - all sheets are unprotected.

Expected results:
Sheets previously set as protected should be protected again.

Does this happen every time?
Yes.

Other information:
Dialog Format->Cells[Protection], checkbox "Protect worksheet" - when checked
protection of workbook is set, NOT of actual worksheet!
Comment 1 Klokan Petr Pridal 2006-03-11 22:05:04 UTC 
Created attachment 61104 [details] [review]
Worksheet protection saved/read support for .gnumeric + dialog repaired.

New bool attribute "Protected" is added under tag "Sheet" into .gnumeric. Change is implemented for both writing and reading (old and new SAX too). All functionality (and GUI too) was prepared inside of Gnumeric, just the saving was missing. Small bug in dialog is repared too.

PLEASE check that patch carefully, it's my first :-).
Comment 2 Morten Welinder 2006-03-12 14:21:07 UTC 
Looks good to me (visually).

Jody: consider for 1.6.4 if you intend to bring that out tonight.
Comment 3 Morten Welinder 2006-03-13 18:29:21 UTC 
fixed in cvs.  (HEAD and 1.6)

Thanks.
Comment 4 Klokan Petr Pridal 2006-03-13 19:12:16 UTC 
Nice.

It would be nice if you commit Excel Import/Export of these funtionality too. Patch is attached to Bug 330129.