After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333845 - Use playlist information HAL reports
Use playlist information HAL reports
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
0.9.x
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 333075 333397 333428 333453 333471 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-08 02:58 UTC by Eugenia Loli-Queru
Modified: 2006-06-18 17:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (16.24 KB, patch)
2006-06-05 22:22 UTC, Jonathan Matthew
committed Details | Review

Description Eugenia Loli-Queru 2006-03-08 02:58:57 UTC
Please describe the problem:
I have filed a bug with HAL about these two kind of players' mounting. The
hal-device info you need is at freedesktop's bug system: 
https://bugs.freedesktop.org/show_bug.cgi?id=6178

So, for the Sansa m2x0 devices, you must add support for the ones that their
names is not only m240 as in the bug report above, but also the ones that are
called m230 and m250 (they are the same device, just different flash storage
size models). The m2x0 models support .WPL and .M3U playlists when put on their
/m2x0/Media/ folder. This is how Windows sees the device and puts music files in
it btw: My Computer\SanDisk Sansa m240\Media (Windows sees these devices as
music players)

As for the e1x0 devices, again, use the HAL info I incorporated on the bug
report above. You will need to add support for the models e130 and e140 (same
device, just different flash storage model again). The e1x0 devices don't
support any kind of playlists. The e1x0 devices also include an SD slot, which
mounts on Nautilus as "e130 (2)" (for those with e130 model, that is). The mp3
files can be tossed in the root folder of the  device. This is how Windows sees
the device: My Computer\SANSA E1XX\ (Windows just sees it as a removable drive,
not as a music player)

Let me know if you need testing or more info.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Alex Lancaster 2006-03-08 08:26:49 UTC
Tagging as an enhancement in the "Removable Media" component.
Comment 2 James "Doc" Livingston 2006-04-02 05:10:52 UTC
I've made a comment on the HAL bug with the .fdi fragment for the playlist information.

Rhythmbox will detect the player once HAL identifies it as an audio player. Rhythmbox currently doesn't use the playlist information that HAL now reports, so retitling the bug to reflect that.
Comment 3 James "Doc" Livingston 2006-04-02 05:22:32 UTC
*** Bug 333428 has been marked as a duplicate of this bug. ***
Comment 4 James "Doc" Livingston 2006-04-02 05:23:11 UTC
*** Bug 333453 has been marked as a duplicate of this bug. ***
Comment 5 James "Doc" Livingston 2006-04-02 05:23:32 UTC
*** Bug 333471 has been marked as a duplicate of this bug. ***
Comment 6 James "Doc" Livingston 2006-04-02 05:24:32 UTC
*** Bug 333397 has been marked as a duplicate of this bug. ***
Comment 7 James "Doc" Livingston 2006-04-02 05:25:07 UTC
*** Bug 333075 has been marked as a duplicate of this bug. ***
Comment 8 Jonathan Matthew 2006-06-05 22:22:15 UTC
Created attachment 66798 [details] [review]
patch

Reads the various bits of information from HAL, and attempts to use them.  I haven't tested much of this.  It doesn't provide a way for subclasses (PSP, nokia770) to set the same information, but I don't think they need to do that.
Comment 9 James "Doc" Livingston 2006-06-06 13:50:35 UTC
I can't check (lacking an audio player) but it looks sane to me.

The subclasses only exist due to HAL lacking the necessary information to support them, and can get removed sometime. If HAL doesn't know about PSPs yet, it should just be a matter of adding the info to the .fdi files. Currently HAL doesn't have anything about the format of entries in the playlist files, so we need to keep the Nokia source for now.
Comment 10 James "Doc" Livingston 2006-06-18 10:41:22 UTC
This can probably be committed now 0.9.5 is out.
Comment 11 Jonathan Matthew 2006-06-18 17:08:05 UTC
committed to cvs.