GNOME Bugzilla – Bug 333667
[PATCH] MusicBrainz metadata lookup does not function with a proxy server
Last modified: 2006-03-15 18:03:37 UTC
Please describe the problem: Banshee is unable to perform metadata lookups when internet access is only available via an http proxy server. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 60799 [details] [review] A simple patch to add proxy support Here is a small patch that automatically sets the proxy server for libmusicbrainz using Mono's proxy settings. These can be set in .config files, and since October are by default loaded from the conventional http_proxy environment variable. I wan't sure exactly where to add in this support, but the easiest way of making sure it gets everywhere was to put it into the MusicBrainz.Client constructor. If it were to happen at any other time, for example after setting the server, there might be some nasty surprises for people who want to set the proxy manually. For this scenario I added a public method to make it easy to re-lookup the proxy based on server address. Note that GlobalProxySelection has been deprecated in .NET 2, but replacements doesn't exist in .NET 1.1. A proxy server address can be found in gconf, but I didn't think a gconf dependency would be good for musicbrainz-sharp. I guess this should really go into the musicbrainz-sharp repository, so that other projects can get it when they sync. Could someone test this patch on a machine that doesn't need a proxy, to make sure it doesn't break anything? It works fine with the proxy on mine :-)
Committed. Thanks!