After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333624 - invalid get_times implementation in gstdynudpsink
invalid get_times implementation in gstdynudpsink
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal major
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-06 15:20 UTC by Kai Vehmanen
Modified: 2006-03-07 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert to using basesink get_times() implementation in dynudpsink. (1.50 KB, patch)
2006-03-06 15:23 UTC, Kai Vehmanen 		none Details | Review

Description Kai Vehmanen 2006-03-06 15:20:45 UTC 
Please describe the problem:
The get_times() implementation of dynudpsink does not handle invalid
timestamp/duration values. As a consequence, gstbasesink triggers out-of-segment
warning messages on the pipeline  bus for each buffer processed by dynudpsink,
making the applications unusable.

This bug is only triggered by gstreamer-0.10.3 and newer, which added the
out-of-segment check (gstbasesink.c:gst_base_sink_get_sync_times()).



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
Yes.

Other information:
The bug was found by a user of the sofsip_cli SIP/VoIP client. See 
https://sourceforge.net/tracker/index.php?func=detail&aid=1442875&group_id=143636&atid=756076
Comment 1 Kai Vehmanen 2006-03-06 15:23:23 UTC 
Created attachment 60764 [details] [review]
Revert to using basesink get_times() implementation in dynudpsink.

Fixes the bug (test application sofsip_cli).
Comment 2 Wim Taymans 2006-03-07 17:31:50 UTC 
yeah, silly bit of code. reverting, default implementation does the right thing.

        * gst/udp/gstdynudpsink.c: (gst_dynudpsink_class_init):
        Applied patch from Kai Vehmanen, fixes #333624.