GNOME Bugzilla – Bug 333465
Dbus'component's PlayPause method call is uninteresting
Last modified: 2006-03-21 07:39:20 UTC
There is no method call or signal to know if audio or video is paused or playing anyway :-/ This bug was reported by D.Ciabrini. I put it here so I can work on it.
Notice that it's for post-2.0.
Ok, here is the current (2.0) interface for managing calls in ekiga through dbus: <interface name="net.ekiga.calls"> <method name="GetCallsList"> <arg type="as" direction="out"/> </method> <method name="Connect"> <arg type="s" name="url" direction="in"/> <arg type="s" direction="out"/> </method> <method name="Disconnect"> <arg type="s" name="token" direction="in"/> </method> <method name="PlayPause"> <arg type="s" name="token" direction="in"/> </method> <method name="Transfer"> <arg type="s" name="token" direction="in"/> <arg type="s" name="url" direction="in"/> </method> <method name="ResignalCallInfo"> <arg type="s" name="token" direction="in"/> </method> <signal name="StateChanged"> <arg type="s" name="token"/> <arg type="u" name="state"/> </signal> <signal name="NameInfo"> <arg type="s" name="token"/> <arg type="s" name="name"/> </signal> <signal name="ClientInfo"> <arg type="s" name="token"/> <arg type="s" name="client"/> </signal> <signal name="UrlInfo"> <arg type="s" name="token"/> <arg type="s" name="url"/> </signal> <signal name="ProtocolInfo"> <arg type="s" name="token"/> <arg type="s" name="protocol"/> </signal> </interface> I think the best way to "upgrade" this interface about this issue is by adding a new signal ; something like : <signal name="OnHoldInfo"> <arg type="s" name="token"/> <arg type="b" name="is_on_hold"/> </signal> This means the following changes in ekiga : - add that signal to dbus_stub.xml ; - add a g_signal_emit in ResignalCallInfo's implementation in dbus.cpp ; - add a new function gnomemeeting_dbus_component_set_call_hold in dbus.h ; - implement that function in dbus.cpp ; - call that function from manager.cpp at the right time so the dbus component is notified whenever a call is put on hold/set running again. Should be pretty easy.
Sounds good to me.
Created attachment 61643 [details] [review] Patch to fix the bug according to my proposal Here is the patch I made to implement my proposition. I'm not sure I can apply it now -- we're preparing 2.0.2, not 2.2 yet.
Oh, well, after all if it makes the dbus component better, and doesn't break the rest, then it's stupid to let it rot :-)