After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333392 - [sunaudio] unused variables break CVS build with -Werror
[sunaudio] unused variables break CVS build with -Werror
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-04 18:11 UTC by Benjamin Pineau
Modified: 2006-03-04 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Benjamin Pineau 2006-03-04 18:11:27 UTC 
Hi, the following patch is self explanatory:

Index: sys/sunaudio/gstsunaudiomixerctrl.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-good/sys/sunaudio/gstsunaudiomixerctrl.c,v
retrieving revision 1.2
diff -u -r1.2 gstsunaudiomixerctrl.c
--- sys/sunaudio/gstsunaudiomixerctrl.c 23 Jan 2006 11:06:34 -0000      1.2
+++ sys/sunaudio/gstsunaudiomixerctrl.c 4 Mar 2006 18:04:44 -0000
@@ -136,7 +136,6 @@
 gst_sunaudiomixer_ctrl_get_volume (GstSunAudioMixerCtrl * mixer,
     GstMixerTrack * track, gint * volumes)
 {
-  gint volume;
   struct audio_info audioinfo;
   GstSunAudioMixerTrack *sunaudiotrack = GST_SUNAUDIO_MIXER_TRACK (track);

@@ -168,7 +167,6 @@
     GstMixerTrack * track, gint * volumes)
 {
   gint volume;
-  gchar buf[100];
   struct audio_info audioinfo;
   GstSunAudioMixerTrack *sunaudiotrack = GST_SUNAUDIO_MIXER_TRACK (track);

Index: sys/sunaudio/gstsunaudiomixertrack.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-good/sys/sunaudio/gstsunaudiomixertrack.c,v
retrieving revision 1.1
diff -u -r1.1 gstsunaudiomixertrack.c
--- sys/sunaudio/gstsunaudiomixertrack.c        9 Jan 2006 17:04:52 -0000       1.1
+++ sys/sunaudio/gstsunaudiomixertrack.c        4 Mar 2006 18:04:44 -0000
@@ -89,7 +89,6 @@
 {
   GstSunAudioMixerTrack *sunaudiotrack;
   GstMixerTrack *track;
-  gint volume;

   if (!labels)
     fill_labels ();
Comment 1 Tim-Philipp Müller 2006-03-04 18:58:29 UTC 
Fixed, thanks!

2006-03-04  Tim-Philipp Müller  <tim at centricular dot net>

        * sys/sunaudio/gstsunaudiomixerctrl.c:
        (gst_sunaudiomixer_ctrl_get_volume),
        (gst_sunaudiomixer_ctrl_set_volume):
        * sys/sunaudio/gstsunaudiomixertrack.c:
        (gst_sunaudiomixer_track_new):
          Remove unused variables, breaks build from CVS
          with -Werror (#333392, patch by: Benjamin Pineau)