After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333285 - Implement keybindings
Implement keybindings
Status: RESOLVED FIXED
Product: serpentine
Classification: Deprecated
Component: general
unspecified
Other All
: Normal blocker
: 1.0
Assigned To: Serpentine Maint
Serpentine Maint
Depends on:
Blocks:
 
 
Reported: 2006-03-03 18:03 UTC by Tiago Cogumbreiro
Modified: 2006-06-12 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tiago Cogumbreiro 2006-03-03 18:03:14 UTC
No keybinding shortcut works.
Comment 1 Alan Horkan 2006-04-03 15:00:59 UTC
confirmed using Ubuntu Dapper (Flight 5) and serpentine 0.6.91
keyboard shortcuts do not work

(As oppose to menu accellerators, aka mnemnonics which do work fine.  Maybe the summary should be change?)
Comment 2 Tiago Cogumbreiro 2006-04-13 23:43:41 UTC
I am going to change the following bindings:

Writing the CD: <ctrl>+R
Opening a playlist: <ctrl>+P
Saving a playlist: <ctrl>+S
Adding a file: <ctrl>+A
Removing a track: DEL
Editing a track: ENTER

I am going to remove the following bindings:
- Hide toolbar, currently: T
Comment 3 Alan Horkan 2006-04-14 00:28:47 UTC
First off I should probably say I see Playlist/Project as the default document file in serpentine.  If you wanted to you could simply use Open and Save (and possibly New) in the File menu and not even need to mention playlist but the extra clarity is probably a good thing.  

>> Writing the CD: <ctrl>+R

Not sure.  I tried thinking of this in other ways like "commit" or thinking of the Disc instead of the writing but there still cannot think of a keybinding I'd particularly like for this.  

>> Opening a playlist: <ctrl>+P

Using the standard Open Ctrl+O seems much better in my humble opinion.  
(Maybe also Ctrl+Shift+O for "Open Rhythmbox Playlist" but if you want to change that to import or somethinge else that might not make sense.)  

>> Saving a playlist: <ctrl>+S

No arguement there, makes perfect sense.  

>> Adding a file: <ctrl>+A

Only if you are absolutely sure you will not want to later add something like 
"Edit, Select All  Ctrl+A".  I suppose Clear cover the situation when you might want it but it is a little worrying about how easily you could clear the list and not be able to undo it.  

>> Removing a track: DEL

No arguement.  Might need to make it clear to users there file on disk will not be touched but I think the use of playlists and the label "Remove" should be clear enough.  

>> Editing a track: ENTER

Sounds reasonable, not sure this would need to be shown in the menus or anything.  (This got me thinking about "Rename  F2" or having an item for Properties but I'm getting ahead of myself.)


P.S. If you are drawing influence from any particular applications or other popular Audio CD creator application I'd be interested to know so I could take a look at them and temper my suggestions based on that information.  
Comment 4 Alan Horkan 2006-04-14 00:30:46 UTC
Forgot to mention the importance of writing out the accels (menurc) file somewhere so that users can manually edit it and set custom keybindings if they really want to.  Should be a one liner if you can find the right bit of the API.  
Comment 5 Tiago Cogumbreiro 2006-04-14 01:31:49 UTC
(In reply to comment #3)
> First off I should probably say I see Playlist/Project as the default document
> file in serpentine.  If you wanted to you could simply use Open and Save (and
> possibly New) in the File menu and not even need to mention playlist but the
> extra clarity is probably a good thing.  
That's the common thought in usual CD/DVD authoring applications. But it is not the case in Serpentine. The application contains the tracks you want to write. There's no concept of 'New' because there's only one object, so there's no 'save', 'open' or 'close'.

Turning Serpentine into a document/file centric application would make it less usable because then you would:
 - ask the user to save changes;
 - have to show the user which playlist you would be currently opening;
 - etc.

Maintaining the persistency (which is currently not implemented) would be also more complex since it would have to be set _per file_ (if you want to make it right).

So this is something I want to avoid because for simplicity sake (in UI and in maintainability). Defining the clear distintion in the UI that Serpentine is not a Playlist makes it all easier in the end.

 
> >> Writing the CD: <ctrl>+R
> 
> Not sure.  I tried thinking of this in other ways like "commit" or thinking of
> the Disc instead of the writing but there still cannot think of a keybinding
> I'd particularly like for this.  
K3B uses <ctrl>+B

> >> Opening a playlist: <ctrl>+P
> 
> Using the standard Open Ctrl+O seems much better in my humble opinion.  
> (Maybe also Ctrl+Shift+O for "Open Rhythmbox Playlist" but if you want to
> change that to import or somethinge else that might not make sense.)  
Again, the usage of <ctrl>+O was to underline the though I explained before.
Maybe I should change it to "Import playlist" and use <ctrl>+I ?

 
> Only if you are absolutely sure you will not want to later add something like 
> "Edit, Select All  Ctrl+A".  I suppose Clear cover the situation when you might
> want it but it is a little worrying about how easily you could clear the list
> and not be able to undo it.  
Then let's add the possibility to undo actions instead! Ctrl+A for selecting all makes sense when you have an icon view other wise just select the first element and shift+end.
 
> >> Removing a track: DEL
> 
> No arguement.  Might need to make it clear to users there file on disk will not
> be touched but I think the use of playlists and the label "Remove" should be
> clear enough.
That's a very important idea that needs to be passed to the user. I've seen a user move files to a nautilus-cd-burner project, remove them afterwards and *then* burn. That's because it gave him the false sense of being copied.

> 
> >> Editing a track: ENTER
> 
> Sounds reasonable, not sure this would need to be shown in the menus or
> anything.  (This got me thinking about "Rename  F2" or having an item for
> Properties but I'm getting ahead of myself.)
Hmm, F2 is interesting. Properties? What for?

 
> P.S. If you are drawing influence from any particular applications or other
> popular Audio CD creator application I'd be interested to know so I could take
> a look at them and temper my suggestions based on that information.  
Hmm, we have gnome-baker, gravedigger (or something like that) and K3B. Oh and there's also Rhythmbox.
Comment 6 Tiago Cogumbreiro 2006-06-12 19:20:26 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.

I've used <Ctrl>+O to open playlists as you've advised.

Editing tracks is using the default treeview keybinding which is pressing <Enter>.