Bug 333263 – Notify property change when changing drive

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 333263 - Notify property change when changing drive


Summary:	Notify property change when changing drive


Status:	RESOLVED FIXED

Product:	nautilus-cd-burner
Classification:	Deprecated
Component:	cd-burner
Version:	2.13.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Nautilus CD Burner Maintainers
QA Contact:	Nautilus CD Burner Maintainers

URL:
Whiteboard:

Depends on:
Blocks:	333220

Reported:	2006-03-03 16:07 UTC by Ross Burton
Modified:	2006-03-22 17:02 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Add notify calls (983 bytes, patch) 2006-03-03 16:09 UTC, Ross Burton	accepted-commit_now	Details \| Review
minimal fix (1.27 KB, patch) 2006-03-13 17:32 UTC, William Jon McCann	none	Details \| Review
better fix? (1.67 KB, patch) 2006-03-13 17:41 UTC, William Jon McCann	committed	Details \| Review

Description Ross Burton 2006-03-03 16:07:04 UTC

The most excellent library libgconf-bridge relies on gobject properties emiting notify when they change to sync the properties to GConf.  However, NautilusBurnDriveSelector never does this.  Attaching a patch, which would be *really nice* to have in 2.14 (so I don't have to revert some code).

Comment 1 Ross Burton 2006-03-03 16:09:34 UTC

Created attachment 60576 [details] [review]
Add notify calls

I think I've got just the right number of calls, not too many and not too few.

Comment 2 William Jon McCann 2006-03-03 16:17:31 UTC

Looks OK.  If it works for you then go for it.  Thanks.

Comment 3 Ross Burton 2006-03-03 16:49:16 UTC

Committed, thanks.

Comment 4 William Jon McCann 2006-03-13 17:22:02 UTC

Bummer.  This triggers a crash in n-c-b and rhythmbox.

Backtrace was generated from '/home/gnome/bin/nautilus-cd-burner'

Using host libthread_db library "/lib/libthread_db.so.1".
`shared object read from target memory' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1208387904 (LWP 24772)]
0x00769402 in __kernel_vsyscall ()

+ Trace 66911

Thread 1 (Thread -1208387904 (LWP 24772))

#0 __kernel_vsyscall
#1 __waitpid_nocancel
from /lib/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 792

Comment 5 William Jon McCann 2006-03-13 17:27:25 UTC

Looks like we are doing something odd in nautilus_burn_drive_selection_set_recorders_only():

	/* Force a signal out */
	combo_device_changed (NULL, (gpointer) selection);

http://cvs.gnome.org/viewcvs/nautilus-cd-burner/bacon-cd-selection.c?hideattic=0&r1=1.15&r2=1.16

Which was a fix for bug #157387.

Comment 6 William Jon McCann 2006-03-13 17:32:34 UTC

Created attachment 61190 [details] [review]
minimal fix

Comment 7 William Jon McCann 2006-03-13 17:40:28 UTC

Actually, Ross, why aren't we doing the notify on the Selection object in this case (as we are in the others)?

Comment 8 William Jon McCann 2006-03-13 17:41:35 UTC

Created attachment 61191 [details] [review]
better fix?

Comment 9 Ross Burton 2006-03-13 17:45:53 UTC

Looks good to me. Doh.