After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333169 - make the tooltip *charged logic the same as the icon logic
make the tooltip *charged logic the same as the icon logic
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-03-02 19:11 UTC by Dan Williams
Modified: 2006-03-22 22:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dan Williams 2006-03-02 19:11:26 UTC 
tooltip sometimes disagrees with the icon.

On my laptop, HAL says BAT1 is at 89%, while BAT0 is at 100%.  ACPI (/proc/acpi/battery/BATx/state) says that neither battery is charging.  The icon for gpm does _not_ show the lightning bolt, but the tooltip says "Laptop battery charging (93%)".
Comment 1 Richard Hughes 2006-03-02 20:04:37 UTC 
I've just committed this to CVS:

2006-03-02  Richard Hughes  <richard@hughsie.com>
 * src/gpm-power.{c|h} (gpm_power_battery_is_charged): Create this new function so we can put all the logic to determine if the battery is charged in one place, as now sometimes the icon and the tooltip disagree. Should fix bug #333169
 * src/gpm-power.c (power_get_summary_for_battery_kind): Use the new gpm_power_battery_is_charged functionality so that we match the logic used for the icon.
 * src/gpm-manager.c (get_stock_id_helper): Use the new gpm_power_battery_is_charged functionality that we have abstracted out.

Can you confirm that it now works okay? Thanks.

Richard.
Comment 2 Richard Hughes 2006-03-22 22:39:48 UTC 
Works for me, so closing. Please re-open if the issue persists.