After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333151 - Connect to Server lists unsupported protocols
Connect to Server lists unsupported protocols
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Visual Design
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-03-02 16:27 UTC by Loïc Minier
Modified: 2007-02-26 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (3.79 KB, patch)
2007-02-24 13:25 UTC, Christian Neumair
none Details | Review

Description Loïc Minier 2006-03-02 16:27:11 UTC
Hi,

The "connect to server" dialog lists all protocols it supports, even if gnome-vfs doesn't support this particular protocol:
... (./src/nautilus-connect-server-dialog.c:)
        gtk_combo_box_append_text (GTK_COMBO_BOX (combo),
                                   _("SSH"));
        gtk_combo_box_append_text (GTK_COMBO_BOX (combo),
                                   _("Public FTP"));
        gtk_combo_box_append_text (GTK_COMBO_BOX (combo),
                                   _("FTP (with login)"));
        gtk_combo_box_append_text (GTK_COMBO_BOX (combo),
                                   _("Windows share"));

For example it's possible to create a link to a Windows share on the desktop, even if gnome-vfs doesn't support smb.  This is not very good from an integration perspective, it would be nicer to filter out unsupported protocols.

This is Debian bug http://bugs.debian.org/354984.

Cheers,
Comment 1 Christian Neumair 2007-02-24 13:25:51 UTC
Created attachment 83233 [details] [review]
Proposed patch
Comment 2 Josselin Mouette 2007-02-25 00:34:17 UTC
Works nicely here.
Comment 3 Alexander Larsson 2007-02-26 15:15:34 UTC
Commited. Thanks.