After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333150 - Link activation by Enter after navigating to link by keyboard does not work
Link activation by Enter after navigating to link by keyboard does not work
Status: RESOLVED FIXED
Product: galeon
Classification: Deprecated
Component: User interface
2.0
Other All
: Normal minor
: 2.0.2
Assigned To: galeon-maint
galeon-maint
Depends on:
Blocks:
 
 
Reported: 2006-03-02 16:25 UTC by Pavel Kácha
Modified: 2006-03-05 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (764 bytes, patch)
2006-03-03 15:21 UTC, Crispin Flowerday (not receiving bugmail) 		committed Details | Review

Description Pavel Kácha 2006-03-02 16:25:01 UTC 
Please describe the problem:
Link activation by Enter after navigating to link by keyboard does not work, it
immediately raises TypeAheadFind toolbar.

Steps to reproduce:
1. Go to about:config, set accessibility.typeaheadfind.autostart to "True".
2. Input some URL (to page containing some links) into URLbar, press Enter.
3. After page loads, pres Tab to navigate to any link.
4. Press Enter.


Actual results:
TypeAheadFind toolbar with empty input raises immediately, subsequent hitting
Enter also has no effect.

Expected results:
Just activate link.

Does this happen every time?
Yes.

Other information:
Interestingly, behavior is slightly different when TypeAheadFind was
intentionaly activated at least once, and then cancelled (Esc). Hitting Enter on
selected link then raises toolbar, but activates link too.

Debian Sid, Galeon 2.0.1-1, libxul0d 1.8.0.1-5
Comment 1 Pavel Kácha 2006-03-02 16:32:23 UTC 
Ctrl-Enter works as expected, toolbar stays away, new Tab or Window gets open. Maybe TypeAheadFind toolbar gets activated by "character" (with no modifier) keys, and under some circumstances Enter is considered as character 0x10, and raises one?
Comment 2 Crispin Flowerday (not receiving bugmail) 2006-03-02 16:33:21 UTC 
Ahh, yeah, I can repro this now ...
Comment 3 Crispin Flowerday (not receiving bugmail) 2006-03-03 15:21:30 UTC 
Created attachment 60572 [details] [review]
Patch

I think this should fix the problem - untested, just made sure it compiles.
Comment 4 Pavel Kácha 2006-03-03 16:55:17 UTC 
I have patched and rebuild Debian Galeon package and works fine in all mentioned cases.

I'm not sure what is bug-closing-politics here, but as I was the only reporter, I'll be using patched Galeon for a few days to see if everything is okay and then I'll close the bug.

Thank you, Crispin!
Comment 5 Crispin Flowerday (not receiving bugmail) 2006-03-03 17:14:43 UTC 
Pavel - thanks for verifying, when I check this into CVS later today, I'll close the bug.
Comment 6 Loïc Minier 2006-03-05 10:07:49 UTC 
Fixes the bug here too.
Comment 7 Crispin Flowerday (not receiving bugmail) 2006-03-05 13:04:51 UTC 
Fixed in CVS:

http://mail.gnome.org/archives/cvs-commits-list/2006-March/msg01067.html