After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 333055 - PYGIL_API_IS_BUGGY is already defined in pygobect.h
PYGIL_API_IS_BUGGY is already defined in pygobect.h
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal major
: 0.10.3
Assigned To: GStreamer Maintainers
Johan (not receiving bugmail) Dahlin
Depends on:
Blocks:
 
 
Reported: 2006-03-01 22:10 UTC by Erik Walthinsen
Modified: 2006-03-02 09:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Erik Walthinsen 2006-03-01 22:10:10 UTC
In pygstminiobject.h (CVS rev 1.4), PYGIL_API_IS_BUGGY is defined based on PY_VERSION_EX.  However, debian's python-gtk2-dev-2.8.2-3 includes a version of pygobject.h that already defines this as TRUE.  Compilation fails with a double-defined macro.

The version check needs to be surrouned with an #ifndef PYGIL_API_IS_BUGGY in order to avoid this problem, or an #undefine beforehand if the value that python-gtk2 defines is not to be trusted.
Comment 1 Edward Hervey 2006-03-02 09:28:49 UTC
May I state for the record that what the debian maintainer did is CRACK ?

From the gobject/pygobject.h file contained in http://ftp.gnome.org/pub/GNOME/sources/pygtk/2.8/pygtk-2.8.2.tar.bz2 :

...

/* This is deprecated, don't use */
#define PYGIL_API_IS_BUGGY FALSE

...
Comment 2 Edward Hervey 2006-03-02 09:41:25 UTC
Fixed in CVS, by undef'ing PYGIL_API_IS_BUGGY beforehand.

2006-03-02  Edward Hervey  <edward@fluendo.com>

        * gst/pygstminiobject.h:
        Some crack distributions do weirdo stuff with PYGIL_API_IS_BUGGY.
        Let's keep our own detection.
        Closes #333055