GNOME Bugzilla – Bug 332889
Broken if srcdir != builddir: this un-breaks it (patch follows)
Last modified: 2006-03-01 10:20:12 UTC
The Makefile insists on referring to files via $(srcdir) or $(top_srcdir), even when they are built objects. In at least one location (building convert.stamp) a 'cd' fails and the search for .png files in the built 'html' directory (originally misdirected to the source tree) is now misdirected to the whole of the build tree, thereby picking up the 'pdf' directory images as well. The failed cd should terminate the rule, so this behaviour is yet another bug. The repair is easy (but tedious to check!) (i) Remove $(srcdir) and $(top_srcdir) when it only ever means "here", in the top level of the build directory (ii) replace ';' with '&&' after the offending cd (I've looked for other similar cases and found none). The result now works cleanly for me to build and install the help docs. I have not actually tried to create a "distribution" tarball, but surely I can't have broken anything which used to work by correcting the paths! The autotools (well, automake and configure, which are the only things that care) are happy with the change.
Created attachment 60351 [details] [review] Repairs building in separate build directory The distributed original file is dated 2005, but live CVS says it's four years old! At one location the build directory must be found from the source tree. @abs_top_builddir@ does the necessary. This could (for consistency) be proxied through a Make variable, like @srcdir@ through $(srcdir), but for a single substitution it seems like overkill.
Not sure how much sense it makes to apply a patch that was created against the 0.9 tarball because a lot has changed since then and there will be further build changes before the 0.10 release. But I've applied it anyway... 2006-03-01 Sven Neumann <sven@gimp.org> * Makefile.am: applied a patch from Bernard Leak (bug #332889).