GNOME Bugzilla – Bug 332884
[Patch] draw_print signal not emitted correctly for embedded objects
Last modified: 2006-03-25 17:52:18 UTC
HTMLEmbedded declares a "draw_print" signal that will be emitted while printing (at least). But the code sends 0 as signal, so no printing of embedded objects is possible. Attached patch (one-liner) should solve this issue.
Created attachment 60350 [details] [review] First try
I confirm that this patch does indeed enable the printing of embedded objects in gtkhtml 3.10.0. Please commit.
rohini:ping
Patch doesn't work when printing mail with textarea.
I would say this is another bug then.
rohini: what "does not work"? is it getting worse (then we should not get the patch in), or does it remain as it was (then we should get it in asap)?
uhm, sorry for changing the patch status, restoring the previous state. seems like firefox's reload button did not update the dropdown menu.
Are we all looking at the same patch? Before patch: g_signal_emit_by_name(GTK_OBJECT(embedded_widget), 0, "draw_print", printer->context); After patch: g_signal_emit_by_name(G_OBJECT(embedded_widget), "draw_print", printer->context); I downloaded the GtkHtml source and tested this patch, not because I doubted the correctness, since it obviously fixes a typo, but because I wanted to see whether it would fix bug#327625, which it does. Surely a patch to pass the *signal-name* as the second argument of g_signal_emit_by_name() is uncontroversial!
Patch can be committed because it fixes a typo. But printing of embedded objects is still not possible. As suggested in comment 5, filed bug 335602. Changing patch-status.
rohini: yeah, in evolution perhaps. that's evo's problem. this is about gnucash. :-)
committed both to cvs head and to gnome-2-14 branch: http://cvs.gnome.org/viewcvs/gtkhtml/src/htmlprinter.c?r1=1.86&r2=1.87 http://cvs.gnome.org/viewcvs/gtkhtml/src/htmlprinter.c?r1=1.86&r2=1.86.2.1 patch will be included in gtkhtml-3.10.1 and gtkhtml-3.11.x. thanks for the patch, closing as fixed.