After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332833 - The i18n handling of gnome-default-applications-properties does not work.
The i18n handling of gnome-default-applications-properties does not work.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
git master
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-28 11:40 UTC by Takeshi AIHANA
Modified: 2006-02-28 20:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Change domain name in glade_xml_new() to NULL (and so on). (1.48 KB, patch)
2006-02-28 11:43 UTC, Takeshi AIHANA 		none Details | Review
default-applications-text-domain-name.patch (2.34 KB, patch)
2006-02-28 15:15 UTC, Luca Cavalli 		committed Details | Review

Description Takeshi AIHANA 2006-02-28 11:40:52 UTC 
Please describe the problem:
The 2.13.x version of gnome-default-applications-properties does not show i18N
translated messages on my locale. The other components in the same version of
gnome-control-center work fine.
It looks that the domain names in glade_xml_new in "gnome-da-capplet.c" are
wrong, which is passed as PACKAGE from Makefile.am, because the running 
gnome-default-applications-properties calls control-center.mo instead of
control-center-2.0 as locale data in strace log.
My work arrround is attached.

Steps to reproduce:
1. Click "Preferred Applications" from "Desktop"->"Setting" on Japanese locale
(ja_JP.utf8).
2. A gnome-default-applications-properties is run.
3. All of messages are not translated, except any entries in pull-down menus
which are retrieved from gnome-default-applications.xml has already generated
with Japanese translation by intltool.


Actual results:
i18N translated messages are disappered.

Expected results:
i18N translated messages are appered (Japanese here).

Does this happen every time?
Yes.

Other information:
I attached a patch to work arround this issue.
Comment 1 Takeshi AIHANA 2006-02-28 11:43:15 UTC 
Created attachment 60313 [details] [review]
Change domain name in glade_xml_new() to NULL (and so on).

The domain name in glade_xml_new looks pointed to the control-center instead of control-cdnter-2.0.
Comment 2 Luca Cavalli 2006-02-28 15:15:29 UTC 
Created attachment 60322 [details] [review]
default-applications-text-domain-name.patch

Takeshi, thanks for the patch. Indeed I missed the correct text domain. I did a very very small rework of the patch. OK to commit?
Comment 3 Takeshi AIHANA 2006-02-28 15:41:34 UTC 
Yes, please. Thanks!
Comment 4 Sebastien Bacher 2006-02-28 16:55:03 UTC 
Why do you use the "#ifdef ENABLE_NLS" for that?
Comment 5 Luca Cavalli 2006-02-28 17:08:45 UTC 
Sebastien, isn't that defined in config.h when i18n is enabled? If not needed consider the #ifdef removed from the patch. btw, also other capplets use it.
Comment 6 Sebastien Bacher 2006-02-28 19:57:34 UTC 
according to a grep only ones capplet use it, anyway no objection from my part, feel free to commit
Comment 7 Luca Cavalli 2006-02-28 20:21:03 UTC 
Done. Since both versions seem to be used by gnome modules, I kept the #ifdef.