GNOME Bugzilla – Bug 332645
should either use its own background colour, or link colour according to the system background colour
Last modified: 2006-07-24 11:56:06 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/yelp/+bug/32830 "With a theme with just the wrong coloured background, the links in yelp are unreadable. Yelp seems to assume that blue will be readable on any background. Yelp should either use its own background colour, or it should change link colour according to the system background colour. ... > Thanks for your bug. What version of Ubuntu and theme do you use? ... I am using up-to-date dapper, and the controls theme was a slightly modified blueheart (the modification was to adjust the colours for the gamma of my display since GTK doesn't seem to do this itself). ... > Could you give a pointer to that theme so it's possible for people to try that change? ... I got the theme from the gnome art manager, then modified the html hex colours for the gamma of my display, which is 1.0 while the colours of the theme are for 2.2 (<rant>and gtk, annoyingly, doesn't seem to adjust *any* colours, so all my icons are still far too bright</rant>). I will add the modified gtkrc as an attachment in a moment. http://librarian.launchpad.net/1587595/gtkrc gtkrc from blueheart theme, but with html hexcodes modified for a display with gamma=1.0"
Can you try setting "browser.display.use_system_colors" pref to PR_TRUE in src/yelp-gecko-utils.cpp:yelp_gecko_set_color ?
Yelp is currently broken for me on Ubuntu. So I will try to remember to try that when I next notice it working.
distribution comment: "http://librarian.launchpad.net/2024885/Screenshot.png Screenshot after applying change suggested by upstream. It is identical to before apply thing the change - it doesn't appear to have had an effect." A part of the issue is due to a distro patch: "diff -Nur yelp-2.14.0/stylesheets/yelp-common.xsl yelp-2.14.0.new/stylesheets/yelp-common.xsl --- yelp-2.14.0/stylesheets/yelp-common.xsl 2005-05-20 00:41:16.000000000 +0200 +++ yelp-2.14.0.new/stylesheets/yelp-common.xsl 2006-04-06 16:20:46.000000000 +0200 @@ -47,7 +47,7 @@ h2 { font-size: 1.2em; } h1 + div h2[class~="title"] { margin-top: 2em; } h1, h2, h3, h4, h5, h6, h7 { color: </xsl:text> - <xsl:value-of select="$yelp.color.gray.fg"/><xsl:text>; } + <xsl:value-of select="$yelp.color.selected.bg.dark1"/><xsl:text>; } h3 span[class~="title"] { border-bottom: none; } h4 span[class~="title"] { border-bottom: none; } h5 span[class~="title"] { border-bottom: none; } @@ -81,6 +81,10 @@ color: </xsl:text> <xsl:value-of select="$yelp.color.gray.fg"/><xsl:text>; } + + a { color: </xsl:text> + <xsl:value-of select="$yelp.color.selected.bg.dark1"/><xsl:text>; } + a[class~="linktrail"] { text-decoration: none; } a[class~="linktrail"]:hover { text-decoration: underline; } </xsl:text>" Changing '"browser.display.use_system_colors" pref to PR_TRUE' has apparent effect on the color
As of now, Yelp looks up the link colour from the current theme. If this isn't defined, blue is used. I think this is fixed. Any problems are the theme's fault for not defining a link colour. The correct way to define a link colour is: GtkWidget::link-color = "#<color>" in the appropriate section of the themes gtkrc. Marking as fixed. If you disagree, please reopen.