After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332598 - port modplug to 0.10
port modplug to 0.10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-26 07:54 UTC by Jonathan Matthew
Modified: 2006-05-03 21:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
port (35.56 KB, patch)
2006-02-26 08:02 UTC, Jonathan Matthew
committed Details | Review

Description Jonathan Matthew 2006-02-26 07:54:56 UTC
I've got modplug basically ported.  It behaves a little oddly when (inside playbin) stopping before EOS, but apart from that it's working well.
Comment 1 Jonathan Matthew 2006-02-26 08:02:17 UTC
Created attachment 60142 [details] [review]
port

A couple of changes to the code in gst/modplug/libmodplug/ were required to get it to compile, and I had to explicitly link it against libstdc++.  I haven't looked into what's required on the plugin documentation side of things.
Comment 2 Christophe Fergeau 2006-03-08 12:46:02 UTC
Here are a few (tiny) nitpicks after a quick glance through it (based on the comments __tim made on the code of a plugin I worked on ;)
* in gst_modplug_class_init you can get rid of the parent_class setting, GST_BOILERPLATE does it for you
* in the same function, you should use GST_DEBUG_FUNCPTR when setting up virtual function pointers (set_property, get_property, ...)
* in  gst_modplug_src_event, in EVENT_SEEK when you don't get a GST_FORMAT_TIME query, I think you are leaking 'event'
* in gst_modplug_src_event, I'd set the var 'res' to the result of gst_pad_push_event when possible

There may be more fundamental issues in your code, but my experience with gst is pretty limited, so I can only make some not that useful comments ;)
Comment 3 Tim-Philipp Müller 2006-03-10 17:16:03 UTC
Committed with a bunch of minor fixes and changes here and there. Works perfectly fine for me in totem. Thanks a lot for the port!

2006-03-10  Tim-Philipp Müller  <tim at centricular dot net>

        * configure.ac:
        * gst/modplug/Makefile.am:
        * gst/modplug/gstmodplug.cc:
        * gst/modplug/gstmodplug.h:
        * gst/modplug/libmodplug/sndfile.cpp:
        * gst/modplug/libmodplug/sndfile.h:
          modplug plugin ported to 0.10 (#332598, patch by:
          Jonathan Matthew <jonathan at kaolin wh9 net>).