GNOME Bugzilla – Bug 332598
port modplug to 0.10
Last modified: 2006-05-03 21:54:08 UTC
I've got modplug basically ported. It behaves a little oddly when (inside playbin) stopping before EOS, but apart from that it's working well.
Created attachment 60142 [details] [review] port A couple of changes to the code in gst/modplug/libmodplug/ were required to get it to compile, and I had to explicitly link it against libstdc++. I haven't looked into what's required on the plugin documentation side of things.
Here are a few (tiny) nitpicks after a quick glance through it (based on the comments __tim made on the code of a plugin I worked on ;) * in gst_modplug_class_init you can get rid of the parent_class setting, GST_BOILERPLATE does it for you * in the same function, you should use GST_DEBUG_FUNCPTR when setting up virtual function pointers (set_property, get_property, ...) * in gst_modplug_src_event, in EVENT_SEEK when you don't get a GST_FORMAT_TIME query, I think you are leaking 'event' * in gst_modplug_src_event, I'd set the var 'res' to the result of gst_pad_push_event when possible There may be more fundamental issues in your code, but my experience with gst is pretty limited, so I can only make some not that useful comments ;)
Committed with a bunch of minor fixes and changes here and there. Works perfectly fine for me in totem. Thanks a lot for the port! 2006-03-10 Tim-Philipp Müller <tim at centricular dot net> * configure.ac: * gst/modplug/Makefile.am: * gst/modplug/gstmodplug.cc: * gst/modplug/gstmodplug.h: * gst/modplug/libmodplug/sndfile.cpp: * gst/modplug/libmodplug/sndfile.h: modplug plugin ported to 0.10 (#332598, patch by: Jonathan Matthew <jonathan at kaolin wh9 net>).