After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332557 - FFmpeg video scale port to 0.10
FFmpeg video scale port to 0.10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal enhancement
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-25 17:25 UTC by Michal Benes
Modified: 2006-03-01 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
FFvideoscale port (25.30 KB, patch)
2006-02-25 17:27 UTC, Michal Benes
none Details | Review

Description Michal Benes 2006-02-25 17:25:34 UTC
The attached patch ports ffmpeg video scale to gst-0.10.
Some code is taken from videoscale element.
The actual work was done by Martin Zlomek (added to copyright notice)
Comment 1 Michal Benes 2006-02-25 17:27:20 UTC
Created attachment 60112 [details] [review]
FFvideoscale port
Comment 2 Edward Hervey 2006-02-27 18:15:51 UTC
No major objections, seems to work. What seems weird is that it's just doing straightforward nearest-neighbour rescaling. Isn't there other modes ? If not we already have videoscale in -base.
Comment 3 Michal Benes 2006-02-28 08:59:57 UTC
Hello, the source code of the rescaler states that it does
"High quality image resampling with polyphase filters"
I have done two tests by
gst-launch videotestsrc ! video/x-raw-yuv,width=320,height=200 ! ffvideoscale ! video/x-raw-yuv,width=160,height=100 ! ffmpegcolorspace ! ximagesink
and
gst-launch videotestsrc ! video/x-raw-yuv,width=320,height=200 ! ffvideoscale ! video/x-raw-yuv,width=640,height=400 ! ffmpegcolorspace ! ximagesink
In both cases, the picture is interpolated.

Why do you think that your setup does just nearest-neighbour rescaling?
Comment 4 Edward Hervey 2006-03-01 15:08:33 UTC
Commited in CVS. Thanks,

2006-03-01  Michal Benes  <michal dot benes at xeris dot cz>

	Reviewed by : Edward Hervey  <edward@fluendo.com>

	* ext/ffmpeg/Makefile.am:
	* ext/ffmpeg/gstffmpeg.c: (plugin_init):
	* ext/ffmpeg/gstffmpegscale.c: (gst_ffmpegscale_base_init),
	(gst_ffmpegscale_class_init), (gst_ffmpegscale_init),
	(gst_ffmpegscale_finalize), (gst_ffmpegscale_transform_caps),
	(gst_ffmpegscale_fixate_caps), (gst_ffmpegscale_get_unit_size),
	(gst_ffmpegscale_set_caps), (gst_ffmpegscale_transform),
	(gst_ffmpegscale_handle_src_event), (gst_ffmpegscale_register):
	Port of ffvideoscale to 0.10.
	Closes #332557