After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332538 - Pango (cairo/win32) lost the ability to render glyphs
Pango (cairo/win32) lost the ability to render glyphs
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: win32
1.11.x
Other Windows
: Normal blocker
: ---
Assigned To: gtk-win32 maintainers
pango-maint
Depends on:
Blocks:
 
 
Reported: 2006-02-25 14:41 UTC by Hans Breuer
Modified: 2006-02-27 00:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
If you are curious how it looks like ... (9.74 KB, image/png)
2006-02-25 14:55 UTC, Hans Breuer
Details

Description Hans Breuer 2006-02-25 14:41:39 UTC
Just build from cvs and tried testgtk with newest Pango. Every glyph
is replaced by the "unknown" box. Pango 1.10.x still works fine with 
the same build options and the same cairo version.

A short look at the (win32 specific) changes from 1.10 to 1.11 does
not reveal any obvious fault.
Comment 1 Hans Breuer 2006-02-25 14:55:23 UTC
Created attachment 60109 [details]
If you are curious how it looks like ...
Comment 2 Behdad Esfahbod 2006-02-25 14:58:13 UTC
Oops.  Should be my fault somewhere.  Can you try 0.11.{3,4,5} and see where that has been broken?
Comment 3 Hans Breuer 2006-02-25 15:48:49 UTC
It got broken from 1.11.3 to 1.11.4; now I'm looking at the diffs again;)
Comment 4 J. Ali Harlow 2006-02-25 15:49:23 UTC
Strange. I've just switched to pango 1.11.6 at work (gtk+ 2.8.12, glib 2.9.6, cairo 1.0.2) and haven't noticed any problems. Admittedly, I just installed the new version of the application and checked that it started up correctly (I develop under linux). I could find on Monday that there are problems, but the initial window seemed to come up correctly.
Comment 5 Hans Breuer 2006-02-25 16:41:03 UTC
Even if it works for you it does not work for me. And there are probably
a bunch of differences between our builds. From the top of my head (and
some guessing):
- you are using mingw, I'm using msvc
- you are probably not using built-in modules. I am.
- your build includes the UNISCRIBE dependency, mine does not.
- you may use cairo/ft2. I dont.

BTW: I have found the issue, it was a missing return TRUE in
pango_cairo_win32_font_install(). Will commit shortly.
Comment 6 Hans Breuer 2006-02-25 17:34:54 UTC
2006-02-25  Hans Breuer  <hans@breuer.org>

	* pango/pangocairo-win32font.c(pango_cairo_win32_font_install) :
	return TRUE to glyphs rendered at all (instead of box). This may
	be compiler specific (what to return w/o return) but fixes bug #332538
	
	* pango/makefile.msc : updated
	* pango/pango.def : just some sorting

Comment 7 Tor Lillqvist 2006-02-27 00:01:33 UTC
Thanks! I had noticed the same problem, too, so it wasn't compiler specific. 
Comment 8 Behdad Esfahbod 2006-02-27 00:10:13 UTC
The return value is typically whatever is left in eax or something, so it's very fragile...