Sorry for the wrong setting, I was meaning to pick "minor", the focus has probably changed

Do we want to emit notifications for all changes?  Only for specific properties (rating, play count, other things that are expected to change)?  Only for the playing entry?

I'm not sure emitting dbus signals for every change is a good idea, since all those signals will go at least as far as the dbus daemon.  Maybe if we didn't emit signals during database loading or for newly added entries, it'd be OK.

Is there a dbus equivalent of g_signal_handler_is_connected? If so, we could use that to know whether to send changes over dbus.

I think notifications should at least be sent for all changes involving the currently playing song.  Otherwise, programs like Music Applet will get out of sync if, say, a song's rating is changed in Rhythmbox.

Created attachment 68217 [details] [review]
patch

Emits dbus signals for changes made to the playing song.  Tested with dbus-monitor, seems to work properly.

Even if there was some way to find out if a signal matches any active watches on the bus, it'd still be a roundtrip to the dbus daemon, so we'd be better off just sending the signal and letting the bus drop it if no one wants to see it.

This looks good to me. Worrying about whether there is something connected to this signal probably isn't worth worrying about, especially since we're already sending the elapsed-changed signal every second anyway.

OK, committed.