After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332290 - Using system libneon
Using system libneon
Status: RESOLVED WONTFIX
Product: gnome-vfs
Classification: Deprecated
Component: Module: http
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: Christian Kellner
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-23 09:25 UTC by Josselin Mouette
Modified: 2008-12-21 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use system libneon (710.90 KB, patch)
2008-12-21 19:47 UTC, palfrey
none Details | Review

Description Josselin Mouette 2006-02-23 09:25:21 UTC
I have noticed that the http module includes the whole libneon sources and links statically to them. However, when libneon is available on the system, it would be much better to use the system version and link dynamically to it.

I can work on that by myself and provide a patch if you don't feel it is important, but first, I'd like to know if this is feasible at all, or if gnome-vfs always requires a specific version, or if there are other good reasons to link statically to neon.
Comment 1 Christian Kellner 2006-02-23 15:05:12 UTC
The problem is that we exchange the whole IO layer of neon to use the gnme-vfs io functions, i.e. Socket Buffer, resolver, ssl, etc, and we also have some customizations to neon regarding http streaming ... this and the fact that neon isnt API stable and we have to port the while method to new api version make this probably a WONTFIX for the next time. Sorry but thanks for taking the time to file the bug and also thanks for the offer to make the patch ... :)

Cheers,
Christian
Comment 2 palfrey 2008-12-21 19:47:21 UTC
Created attachment 125110 [details] [review]
Use system libneon

In case opinions on this have changed in the meanwhile, especially given that gnome-vfs is effectively deprecated (but still significantly used) and that bugs like bug 531442 are cropping up (which is fixed in upstream neon, but not in gnome-vfs' ancient version), here's a patch against current SVN head to use the system libneon. It may not be as efficient, but on the plus side it's up to 4 years newer than the 2004 snapshot in gnome-vfs....