After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332140 - Can't open the mail soffice attachment whoes filename contains localized characters.
Can't open the mail soffice attachment whoes filename contains localized char...
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.6.x (obsolete)
Other All
: Normal major
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-02-22 07:57 UTC by Xiurong Simon Zheng
Modified: 2013-09-13 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
one sample message (6.29 KB, application/x-compressed-tar)
2006-02-22 08:11 UTC, Xiurong Simon Zheng
  Details
transfer filenames from UTF-8 to glib encoding before really saving files. (5.01 KB, patch)
2006-02-28 09:53 UTC, ShiPu
none Details | Review
[Calendar]transfer filenames from UTF-8 to glib encoding before really saving files. (3.61 KB, patch)
2006-03-01 10:17 UTC, ShiPu
none Details | Review
[Mailer]transfer filenames from UTF-8 to glib encoding before really saving files. (1.71 KB, patch)
2006-03-01 10:18 UTC, ShiPu
none Details | Review
[widgets]transfer filenames from UTF-8 to glib encoding before really saving files. (1.80 KB, patch)
2006-03-01 10:19 UTC, ShiPu
none Details | Review

Description Xiurong Simon Zheng 2006-02-22 07:57:53 UTC
Please describe the problem:
When received mail attachment contains localized filename, such as chinese,
sometimes evolution can't open it.

Steps to reproduce:
1. 
2. 
3. 
1.Launch evolution on Solaris zh_cn.GB18030 locale
2.Generate a staroffice file.
3.use thunderbird to send a mail that attaches above staroffice file.
4.use evolution to receive the mail, open the attachment bar box, then
double-click attachment to try to open;


Actual results:
Staroffice 7 pop up a message box, saying "Error loading document ...."

Expected results:
Open the staroffice file properly.

Does this happen every time?
Yes.

Other information:
Comment 1 Xiurong Simon Zheng 2006-02-22 08:11:13 UTC
Created attachment 59912 [details]
one sample message

Can't open attachment on Solaris, but works fine after saving it.
Comment 2 Xiurong Simon Zheng 2006-02-22 10:22:52 UTC
There's the same issue with calander attachment bar.
Comment 3 André Klapper 2006-02-22 12:57:55 UTC
could be a bit related to bug 311482
Comment 4 Xiurong Simon Zheng 2006-02-23 13:48:50 UTC
After looking into code, this bug is a bit different from bug 311482. #311482 is caused by not specifying name encoding correctly when getting attachment list. And this one might be resulted from not transfering filename from utf-8 to glib encoding when saving tempary attachment.
Comment 5 Xiurong Simon Zheng 2006-02-24 11:34:02 UTC
If filename is generated by e_filename_make_safe() or similar functions, it should be transfered from UTF-8 to glib encoding before really saving files. There're several places need to change as below.

e-attachment-bar.c: temp_save_part()
em-utils.c: em_utils_temp_save_part()
e-cal-popup.c: temp_save_part()
comp-edit.c: get_attachment_list()
Comment 6 ShiPu 2006-02-28 09:53:26 UTC
Created attachment 60300 [details] [review]
transfer filenames from UTF-8 to glib encoding before really saving files.
Comment 7 ShiPu 2006-03-01 10:17:58 UTC
Created attachment 60382 [details] [review]
[Calendar]transfer filenames from UTF-8 to glib encoding before really saving files.
Comment 8 ShiPu 2006-03-01 10:18:48 UTC
Created attachment 60383 [details] [review]
[Mailer]transfer filenames from UTF-8 to glib encoding before really saving files.
Comment 9 ShiPu 2006-03-01 10:19:25 UTC
Created attachment 60384 [details] [review]
[widgets]transfer filenames from UTF-8 to glib encoding before really saving files.
Comment 10 Xiurong Simon Zheng 2006-03-06 10:47:44 UTC
Committed all the patches to CVS HEAD.