After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 332101 - More cleanups for evolution
More cleanups for evolution
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
evolution[codecleanup]
Depends on:
Blocks:
 
 
Reported: 2006-02-21 22:01 UTC by Kjartan Maraas
Modified: 2013-09-10 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to clean up warnings (9.90 KB, patch)
2006-02-21 22:03 UTC, Kjartan Maraas
none Details | Review
patch to clean up warnings in the mail component (7.46 KB, patch)
2006-02-21 22:04 UTC, Kjartan Maraas
none Details | Review
patch for warnings in evolution/widgets (2.47 KB, patch)
2006-02-21 22:05 UTC, Kjartan Maraas
none Details | Review
patch for evolution/e-util (3.75 KB, patch)
2006-09-25 12:19 UTC, Kjartan Maraas
reviewed Details | Review
patch for evolution/filter (677 bytes, patch)
2006-09-25 12:20 UTC, Kjartan Maraas
committed Details | Review
patch for evolution/mail (45.11 KB, patch)
2006-09-25 12:21 UTC, Kjartan Maraas
none Details | Review
patch for evolution/shell (2.91 KB, patch)
2006-09-25 12:23 UTC, Kjartan Maraas
none Details | Review
patch for evolution/plugins (18.04 KB, patch)
2006-09-25 12:29 UTC, Kjartan Maraas
none Details | Review
cleanups for evolution/smime (1.69 KB, patch)
2006-09-25 12:36 UTC, Kjartan Maraas
committed Details | Review
patch for evolution/widgets/misc (8.15 KB, patch)
2006-09-25 12:37 UTC, Kjartan Maraas
none Details | Review
patch for evolution/widgets/table (7.63 KB, patch)
2006-09-25 12:37 UTC, Kjartan Maraas
none Details | Review
patch for evolution/composer (3.43 KB, patch)
2006-09-25 12:44 UTC, Kjartan Maraas
none Details | Review
fixes for evolution/calendar (26.02 KB, patch)
2006-09-25 12:46 UTC, Kjartan Maraas
accepted-commit_now Details | Review
patch for evolution/addressbook (6.88 KB, patch)
2006-09-25 12:50 UTC, Kjartan Maraas
committed Details | Review
updated patch for e-util (3.28 KB, patch)
2006-10-01 12:03 UTC, Kjartan Maraas
none Details | Review
updated patch for calendar (30.80 KB, patch)
2006-10-01 12:05 UTC, Kjartan Maraas
committed Details | Review

Description Kjartan Maraas 2006-02-21 22:01:40 UTC
Attaching some new patches with compiler warning cleanups
Comment 1 Kjartan Maraas 2006-02-21 22:03:10 UTC
Created attachment 59882 [details] [review]
patch to clean up warnings
Comment 2 Kjartan Maraas 2006-02-21 22:04:16 UTC
Created attachment 59883 [details] [review]
patch to clean up warnings in the mail component
Comment 3 Kjartan Maraas 2006-02-21 22:05:02 UTC
Created attachment 59884 [details] [review]
patch for warnings in evolution/widgets
Comment 4 Kjartan Maraas 2006-09-25 12:19:05 UTC
Created attachment 73357 [details] [review]
patch for evolution/e-util
Comment 5 Kjartan Maraas 2006-09-25 12:20:21 UTC
Created attachment 73359 [details] [review]
patch for evolution/filter
Comment 6 Kjartan Maraas 2006-09-25 12:21:06 UTC
Created attachment 73360 [details] [review]
patch for evolution/mail
Comment 7 Kjartan Maraas 2006-09-25 12:23:31 UTC
Created attachment 73361 [details] [review]
patch for evolution/shell
Comment 8 Kjartan Maraas 2006-09-25 12:29:26 UTC
Created attachment 73362 [details] [review]
patch for evolution/plugins

- warning fixes
- marks some strings for translation in the plugin description xml
Comment 9 Kjartan Maraas 2006-09-25 12:36:25 UTC
Created attachment 73363 [details] [review]
cleanups for evolution/smime

- quiet a "may be used uninitialized" warning
- fix some signedness warnings by casting
Comment 10 Kjartan Maraas 2006-09-25 12:37:02 UTC
Created attachment 73364 [details] [review]
patch for evolution/widgets/misc

- compiler warning fixes
Comment 11 Kjartan Maraas 2006-09-25 12:37:41 UTC
Created attachment 73365 [details] [review]
patch for evolution/widgets/table

- more compiler warning fixes
Comment 12 Kjartan Maraas 2006-09-25 12:44:02 UTC
Created attachment 73367 [details] [review]
patch for evolution/composer

- compiler warning fixes
Comment 13 Kjartan Maraas 2006-09-25 12:46:05 UTC
Created attachment 73368 [details] [review]
fixes for evolution/calendar
Comment 14 Kjartan Maraas 2006-09-25 12:50:28 UTC
Created attachment 73369 [details] [review]
patch for evolution/addressbook

- compiler warnings
- g_string microoptimizations
Comment 15 André Klapper 2006-09-26 20:45:57 UTC
harish: *poke*
Comment 16 Harish Krishnaswamy 2006-09-30 11:08:17 UTC
Kjartan : Just started reviewing your patches - Thanks for all the contribution love :-).
On the e-util patch : the changes look fine except the removal of header inclusions in eggtrayicon.c and e-xml-utils.c. And the 'differ in signedness' warnings still exist.
Comment 17 Kjartan Maraas 2006-10-01 11:56:22 UTC
I commited the filter, smime and addressbook parts. The calendar patch was reviewed by chen before the weekend on the list, so I've made some changes to that. I'll post the updated patch in bugzilla too for review.
Comment 18 Kjartan Maraas 2006-10-01 12:03:26 UTC
Created attachment 73744 [details] [review]
updated patch for e-util

The e-xml-utils.c change just removes a duplicated #include <string.h>, I think that should be safe. Removed the eggtrayicon.c changes since that should be fixed "upstream" or by moving to GtkStatusIcon I guess.
Comment 19 Kjartan Maraas 2006-10-01 12:05:25 UTC
Created attachment 73745 [details] [review]
updated patch for calendar

This went through some revisions after review on evolution-patches.
Comment 20 Chenthill P 2006-10-16 18:24:36 UTC
(In reply to comment #19)
> updated patch for calendar
The calendar events would not appear in the view with the patch (from comment #19) applied unless a search text is entered. I have replaced the following line

+	    sexp = g_strdup_printf ("(contains? \"summary\" \"%s\")", field); /* Show all */

with 
+ sexp = g_strdup ("(contains? \"summary\" \"\")"); /* Show all */

to fix the issue. The modified patch has been committed to gnome-2-16 and cvs HEAD.

Please test the patch once again just before submitting the patch ;) Thanks in advance.
Comment 21 Srinivasa Ragavan 2007-06-04 18:13:55 UTC
kmaraas, are these patches still valid? I think Gilles has pushed lots of patches to head.
Comment 22 Gilles Dartiguelongue 2007-06-14 20:14:46 UTC
I just read some of these patchs (smallest first) and it seems there is still good stuff to pick in it. They need a refresh though. If I refresh some, I'll attach them here.
Comment 23 Srinivasa Ragavan 2007-08-23 08:38:24 UTC
patch for evolution/shell is more closer to port. But it has bugs like the nm-glib header file included with out any check. Rest of the patches dont apply at all. Gilles/Kmaraas, feel free to submit any new things. I would target them for 2.14.
Comment 24 Kjartan Maraas 2008-11-08 23:06:57 UTC
Closing this bug. I'll file any new cleanups in new reports.