GNOME Bugzilla – Bug 332101
More cleanups for evolution
Last modified: 2013-09-10 13:55:50 UTC
Attaching some new patches with compiler warning cleanups
Created attachment 59882 [details] [review] patch to clean up warnings
Created attachment 59883 [details] [review] patch to clean up warnings in the mail component
Created attachment 59884 [details] [review] patch for warnings in evolution/widgets
Created attachment 73357 [details] [review] patch for evolution/e-util
Created attachment 73359 [details] [review] patch for evolution/filter
Created attachment 73360 [details] [review] patch for evolution/mail
Created attachment 73361 [details] [review] patch for evolution/shell
Created attachment 73362 [details] [review] patch for evolution/plugins - warning fixes - marks some strings for translation in the plugin description xml
Created attachment 73363 [details] [review] cleanups for evolution/smime - quiet a "may be used uninitialized" warning - fix some signedness warnings by casting
Created attachment 73364 [details] [review] patch for evolution/widgets/misc - compiler warning fixes
Created attachment 73365 [details] [review] patch for evolution/widgets/table - more compiler warning fixes
Created attachment 73367 [details] [review] patch for evolution/composer - compiler warning fixes
Created attachment 73368 [details] [review] fixes for evolution/calendar
Created attachment 73369 [details] [review] patch for evolution/addressbook - compiler warnings - g_string microoptimizations
harish: *poke*
Kjartan : Just started reviewing your patches - Thanks for all the contribution love :-). On the e-util patch : the changes look fine except the removal of header inclusions in eggtrayicon.c and e-xml-utils.c. And the 'differ in signedness' warnings still exist.
I commited the filter, smime and addressbook parts. The calendar patch was reviewed by chen before the weekend on the list, so I've made some changes to that. I'll post the updated patch in bugzilla too for review.
Created attachment 73744 [details] [review] updated patch for e-util The e-xml-utils.c change just removes a duplicated #include <string.h>, I think that should be safe. Removed the eggtrayicon.c changes since that should be fixed "upstream" or by moving to GtkStatusIcon I guess.
Created attachment 73745 [details] [review] updated patch for calendar This went through some revisions after review on evolution-patches.
(In reply to comment #19) > updated patch for calendar The calendar events would not appear in the view with the patch (from comment #19) applied unless a search text is entered. I have replaced the following line + sexp = g_strdup_printf ("(contains? \"summary\" \"%s\")", field); /* Show all */ with + sexp = g_strdup ("(contains? \"summary\" \"\")"); /* Show all */ to fix the issue. The modified patch has been committed to gnome-2-16 and cvs HEAD. Please test the patch once again just before submitting the patch ;) Thanks in advance.
kmaraas, are these patches still valid? I think Gilles has pushed lots of patches to head.
I just read some of these patchs (smallest first) and it seems there is still good stuff to pick in it. They need a refresh though. If I refresh some, I'll attach them here.
patch for evolution/shell is more closer to port. But it has bugs like the nm-glib header file included with out any check. Rest of the patches dont apply at all. Gilles/Kmaraas, feel free to submit any new things. I would target them for 2.14.
Closing this bug. I'll file any new cleanups in new reports.