After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331916 - Button reliefs on toolbar
Button reliefs on toolbar
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-02-20 17:39 UTC by Cameron Harris
Modified: 2006-02-23 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove the reliefs on all four buttons mentioned (1.25 KB, patch)
2006-02-20 17:41 UTC, Cameron Harris
none Details | Review

Description Cameron Harris 2006-02-20 17:39:28 UTC
I've noticed that the 3 equation/formula buttons on the toolbar of the workbook
GUI and the select all cells button on the sheet GUI have full reliefs. 

IMHO this causes  unnecessary visual noise and inconsistency with the other
toolbar buttons. It's expected that buttons on a toolbar are clickable, so there
is no need to indicate it with a border.

I think that the reliefs on the three equation buttons should be removed, and
possibly the one for the select all cells button.

Other information:
Comment 1 Cameron Harris 2006-02-20 17:41:18 UTC
Created attachment 59783 [details] [review]
Remove the reliefs on all four buttons mentioned
Comment 2 Morten Welinder 2006-02-23 16:13:38 UTC
2006-02-23  Morten Welinder  <terra@gnome.org>

	* src/workbook-control-gui.c (edit_area_button): Use tool buttons,
	not plain buttons.  Fixes #331916.