GNOME Bugzilla – Bug 331901
[videotestsrc] framerate=0/1 gives assertion error
Last modified: 2006-04-28 14:24:31 UTC
Please describe the problem: gst-launch-0.10 videotestsrc ! video/x-raw-yuv,framerate=1/0 ! xvimagesink complains about assertion denom!=0 expected, should play a single frame that lasts for infinite time. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Whoops typo i meant 0/1 not 1/0
Indeed, you mean gst-launch-0.10 videotestsrc ! video/x-raw-yuv,framerate=0/1 ! xvimagesink videotestsrc doesn't seem to support a framerate of 0.
Created attachment 60721 [details] [review] Partly fix the issue. Still miss a CLOCK_TIME to indicate the buffers should last forever.
a duration of -1 (CLOCK_TIME_NONE) means forever.
Commiting the patch. I guess videotestsrc should EOS after the first infinite buffer because it would take an infinite time to push another buffer (which means EOS to me). setting the duration to -1 is fine, we do that for still frames too. The only thing is that a player would get EOS immediatly after showing the frame, which is sortof correct since nothing is going to happen anymore. This is all a bit silly, but hey!
Created attachment 63464 [details] [review] eos after emiting the first infinite duration frame
* gst/videotestsrc/gstvideotestsrc.c: (gst_video_test_src_create): Handle 0/1 framerate correctly Fixes #331901.