After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331838 - build problem caused by AS_LIBTOOL_TAGS([CXX])
build problem caused by AS_LIBTOOL_TAGS([CXX])
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal major
: 0.10.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-20 01:24 UTC by Mikhail Zabaluev
Modified: 2006-03-28 14:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
remove CXX autoconf foo (514 bytes, patch)
2006-03-06 11:50 UTC, Christian Kirbach
committed Details | Review

Description Mikhail Zabaluev 2006-02-20 01:24:19 UTC
+++ This bug was initially created as a clone of Bug #326683 +++

The point to keep the C++ configure stuff in gst-plugins-ugly may be gone as well.
Comment 1 Jan Schmidt 2006-02-27 15:50:21 UTC
Brian, can you comment on this bug? Should we not be adding the CXX tag here?

unlike the others, gst-plugins-ugly does contain a plugin that uses c++. It will become a problem again for gst-plugins-good at some point too, because there are other plugins in gst-plugins-bad that will probably move there eventually.
Comment 2 Brian Cameron 2006-02-28 01:34:44 UTC
Is the C++ tag in the AS_LIBTOOL_TAGS macro really needed to build the C++ 
plugins?  What breaks if the C++ argument is missing?  The duplicate bug explains what breaks when you add it.  If the C++ tag needs to go back in, then I can take a look at this again and see if there's another way I can fix the Solaris build problem.
Comment 3 Jan Schmidt 2006-02-28 09:07:18 UTC
"Is the C++ tag in the AS_LIBTOOL_TAGS macro really needed to build the C++ 
plugins?"

I have no idea - it's all autotools voodoo pain to me - I was hoping you'd know :)
Comment 4 Brian Cameron 2006-03-03 02:46:40 UTC
Sorry, I don't know if it is needed.  You'll have to test and see.  If it is really needed for GStreamer to build properly, and this breaks the Solaris build again, then I'll find another way to fix the Solaris build.

But if GStreamer builds fine without the option, I don't see any need for adding it.
Comment 5 Jan Schmidt 2006-03-03 12:57:32 UTC
CC'ing thomas and andy for comment then - they're the dudes who are supposed to understand what this macro does.

Comment 6 Andy Wingo 2006-03-04 14:37:28 UTC
I'll take this one, the macro is my fault :)
Comment 7 Christian Kirbach 2006-03-06 11:49:35 UTC
I can see the build problem here as well, and the patch from Bug #326683 remedies.
Comment 8 Christian Kirbach 2006-03-06 11:50:41 UTC
Created attachment 60751 [details] [review]
remove CXX autoconf foo

unbreaks the build :)
Comment 9 Tim-Philipp Müller 2006-03-27 10:10:26 UTC
 2006-03-27  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Christian Kirbach

        * configure.ac:
          Remove CXX tag from AS_LIBTOOL_TAGS, just like we did for
          -good. Fixes build on some systems (#331838).
Comment 10 Jan Schmidt 2006-03-27 13:25:27 UTC
I thought Andy was going to take this one, and actually fix it rather than disabling the CXX tag?
Comment 11 Tim-Philipp Müller 2006-03-27 13:37:33 UTC
Ah, I didn't know there was anything else to fix. We've done the same thing for -good some time ago, so I don't think there are any downsides to just removing the tag.

Reopening then ...
Comment 12 Jan Schmidt 2006-03-27 14:36:29 UTC
aiui, there aren't until we go to reenable C++ based plugins at which point the tag is needed, or something. Andy understands, I believe.

In the meantime, we're probably ok to apply the patch (since there's no C++ based plugins building yet) and leave the bug open for Andy to fix.
Comment 13 Andy Wingo 2006-03-28 07:43:44 UTC
As has been made apparent, I'm quite OK with ignoring the problem :-P

Just go ahead and close it I guess.