GNOME Bugzilla – Bug 331735
Bug in gnome-doc-utils.m4 leads to errors for distcheck target
Last modified: 2006-05-29 17:32:56 UTC
Hello, In gnome-doc-utils.m4 it is written AC_OUTPUT_COMMANDS([ gdumk=`pkg-config --variable datadir gnome-doc-utils`/gnome-doc-utils/gnome-doc-utils.make if test -f $srcdir/gnome-doc-utils.m4; then if ! cmp -s $srcdir/gnome-doc-utils.make gnome-doc-utils.make; then cp $srcdir/gnome-doc-utils.make gnome-doc-utils.make fi else if ! cmp -s $gdumk gnome-doc-utils.make; then cp $gdumk gnome-doc-utils.make fi fi if ! grep 'gnome-doc-utils\.make' $ac_top_srcdir/Makefile.am >/dev/null; then echo gnome-doc-utils.make should be added to EXTRA_DIST in Makefile.am fi ]) The problem is, that you test on the existence of gnome-doc-utils.m4, which is IMO not right, because you want to test on gnome-doc-utils.make and then update or create this file if necessary.
I forgot: When you now run 'make distcheck', gnome-doc-utils.make is copied to $(build_dir), which is not necessary and not intended, because $(top_srcdir)/gnome-doc-utils.make exists. The result is an error from the distcleancheck target.
No response after at least more than 3 weeks? Is there any problem with the bug-report?
*** Bug 338021 has been marked as a duplicate of this bug. ***
*** Bug 335562 has been marked as a duplicate of this bug. ***
Can somebody please care about this really annoying bug? This is now the 4th entry in this report after 3 months without any response, but 2 more reports about the same problem. This bug breaks the 'make distcheck' target for all packages, which use gnome-doc-utils! Can you please fix it?
> if test -f $srcdir/gnome-doc-utils.m4; then > if ! cmp -s $srcdir/gnome-doc-utils.make gnome-doc-utils.make; then > cp $srcdir/gnome-doc-utils.make gnome-doc-utils.make > fi > else > if ! cmp -s $gdumk gnome-doc-utils.make; then > cp $gdumk gnome-doc-utils.make > fi > fi Here are several issues. 1) You test on the .m4 file instead of the .make file. 2) You test, if $srcdir/gnome-doc-utils.make exists, but you copy it from $srcdir/$gdumk to $builddir, which causes make distcheck to fail. I suggest the following: if test -f $srcdir/gnome-doc-utils.make; then if ! cmp -s $gdumk $srcdir/gnome-doc-utils.make; then cp $gdumk $srcdir fi else cp $gdumk $srcdir fi Alternatively you need to search through $srcdir (and subdirs) for files called gnome-doc-utils.make und then you compare found files with $gdumk and if those files differ, you copy the file to the location, where you found the file (as long as you don't have a default location, where the .make file should be found, like gettext e.g. has). If you don't find any file, copy $gdumk explicetely to $srcdir. What about this?
That whole AC_OUTPUT_COMMANDS should just die. It was put in before we had gnome-doc-prepare in place. By the way, the top half where "test -f $srcdir/gnome-doc-utils.m4" would succeed, was intentional. The only package that should ever have gnome-doc-utils.m4 in $srcdir is gnome-doc-utils itself. There are a number of oddities in the build files to allow gnome-doc-utils to use itself.
Done. Please let me know if this leads to any problems.
Many thanks for the clarification and for fixing this bug. It solves the 'make distcheck' issue. ATM I cannot see any negative impact.