After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 331604 - Remove redundant search control
Remove redundant search control
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2006-02-17 20:38 UTC by Joe Shaw
Modified: 2006-02-19 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot showing the pointlessness. :) (12.70 KB, image/png)
2006-02-17 20:41 UTC, Joe Shaw 		  Details
Patch which removes the control (978 bytes, patch)
2006-02-17 20:43 UTC, Joe Shaw 		committed Details | Review

Description Joe Shaw 2006-02-17 20:38:08 UTC 
If you run a search in Yelp, you'll get results back with a search field:

Search help: [ terminal          ] [Go]

This control is pretty redundant, because there is a search control in the toolbar UI immediately above it which maintains the focus when you type a search into it.

I'll attach a screenshot and a patch.
Comment 1 Joe Shaw 2006-02-17 20:41:23 UTC 
Created attachment 59611 [details]
Screenshot showing the pointlessness. :)
Comment 2 Joe Shaw 2006-02-17 20:43:02 UTC 
Created attachment 59614 [details] [review]
Patch which removes the control

With this we can and should also remove the search-header.xsl file.
Comment 3 Brent Smith (smitten) 2006-02-19 06:25:28 UTC 
yes, I agree this needs to go.  Another reason this should die: the search-header.xsl file is not translated.

I will bring this up to release team so that we can break the UI Freeze.
Comment 4 Brent Smith (smitten) 2006-02-19 14:27:04 UTC 
Thanks Joe.

http://mail.gnome.org/archives/release-team/2006-February/msg00208.html

2006-02-18  Brent Smith  <gnome@nextreality.net>

        * stylesheets/search-header.xsl:
        * stylesheets/search2html.xsl:
        Removed redundant search text entry; search-header.xsl no longer
        needed and removed from CVS.  Patch from Joe Shaw, Fixes #331604